From: "Jan Beulich" <JBeulich@novell.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Joanna Rutkowska <joanna@invisiblethingslab.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Keir Fraser <Keir.Fraser@eu.citrix.com>,
Daniel Stodden <daniel.stodden@citrix.com>
Subject: Re: Xen 4.0.0x allows for data corruption in Dom0
Date: Tue, 09 Mar 2010 10:15:17 +0000 [thread overview]
Message-ID: <4B962DC5020000780003371B@vpn.id2.novell.com> (raw)
In-Reply-To: <4B9624FD02000078000336EA@vpn.id2.novell.com>
>>> "Jan Beulich" <JBeulich@novell.com> 09.03.10 10:37 >>>
>How about these being vcpu_time_info structures? The fields
>appear to all make sense. The only thing not matching this would
>be a few differently looking corruption entries sent earlier by Joanna,
>so this may not be the only thing. But it would explain why with 3.4.2
>the issue is not present.
In particular I think the update_vcpu_system_time() invocation
in schedule() isn't right - VCPUOP_register_vcpu_time_memory_area
taking a virtual address, this call must not happen before
context_switch().
And btw., 32-on-64 also seems to be broken for
VCPUOP_register_vcpu_time_memory_area (since 64-bit Xen reads
the full 64-bit field).
Jan
next prev parent reply other threads:[~2010-03-09 10:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <C7B7F4C4.C5D8%keir.fraser@eu.citrix.com>
2010-03-06 13:36 ` Xen 4.0.0x allows for data corruption in Dom0 Keir Fraser
2010-03-07 14:36 ` Pasi Kärkkäinen
2010-03-07 14:39 ` Keir Fraser
2010-03-07 16:12 ` Pasi Kärkkäinen
2010-03-08 23:22 ` Daniel Stodden
2010-03-08 23:30 ` Joanna Rutkowska
2010-03-08 23:52 ` Daniel Stodden
2010-03-08 23:56 ` Joanna Rutkowska
2010-03-09 0:33 ` Daniel Stodden
2010-03-09 8:25 ` Pasi Kärkkäinen
2010-03-09 9:37 ` Jan Beulich
2010-03-09 10:15 ` Jan Beulich [this message]
2010-03-09 10:17 ` Keir Fraser
2010-03-09 10:15 ` Keir Fraser
2010-03-09 10:25 ` Pasi Kärkkäinen
2010-03-09 10:43 ` Keir Fraser
2010-03-09 12:03 ` Pasi Kärkkäinen
2010-03-09 10:42 ` Jan Beulich
2010-03-09 23:28 ` Jeremy Fitzhardinge
2010-03-10 1:33 ` Dan Magenheimer
2010-03-10 18:02 ` Jeremy Fitzhardinge
[not found] <C7B80F95.C5F3%keir.fraser@eu.citrix.com>
2010-03-06 13:37 ` Joanna Rutkowska
2010-03-06 17:18 ` Keir Fraser
[not found] <4B922A89.2060105@invisiblethingslab.com>
2010-03-08 22:24 ` Jeremy Fitzhardinge
2010-03-08 22:34 ` Joanna Rutkowska
2010-03-08 23:12 ` Jeremy Fitzhardinge
2010-03-08 23:23 ` Joanna Rutkowska
2010-03-08 23:41 ` Jeremy Fitzhardinge
2010-03-08 23:48 ` Joanna Rutkowska
2010-03-09 0:18 ` James Harper
2010-03-09 0:20 ` Joanna Rutkowska
2010-03-08 23:32 ` Daniel Stodden
[not found] ` <4B958A42.4000407@invisiblethingslab.com>
2010-03-08 23:46 ` Daniel Stodden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B962DC5020000780003371B@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=Keir.Fraser@eu.citrix.com \
--cc=daniel.stodden@citrix.com \
--cc=jeremy@goop.org \
--cc=joanna@invisiblethingslab.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).