From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] XEN: Make handle_vcpu_hotplug_event() to check the sscanf()
 return value
Date: Fri, 12 Mar 2010 16:39:28 -0800
Message-ID: <4B9ADEC0.60302@goop.org>
References: <20100312025324.GC2712@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20100312025324.GC2712@localhost.localdomain>
Sender: linux-kernel-owner@vger.kernel.org
To: wzt.wzt@gmail.com
Cc: linux-kernel@vger.kernel.org, xen-devel@lists.xensource.com, jeremy@xensource.com
List-Id: xen-devel@lists.xenproject.org

On 03/11/2010 06:53 PM, wzt.wzt@gmail.com wrote:
> It seems handle_vcpu_hotplug_event() not check the sscanf() return value.
>
> Signed-off-by: Zhitong Wang<zhitong.wangzt@alibaba-inc.com>
>    

Good catch, thanks.

     J

> ---
>   drivers/xen/cpu_hotplug.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/xen/cpu_hotplug.c b/drivers/xen/cpu_hotplug.c
> index 14e2d99..99773a6 100644
> --- a/drivers/xen/cpu_hotplug.c
> +++ b/drivers/xen/cpu_hotplug.c
> @@ -69,8 +69,8 @@ static void handle_vcpu_hotplug_event(struct xenbus_watch *watch,
>
>   	cpustr = strstr(node, "cpu/");
>   	if (cpustr != NULL) {
> -		sscanf(cpustr, "cpu/%u",&cpu);
> -		vcpu_hotplug(cpu);
> +		if (sscanf(cpustr, "cpu/%u",&cpu) == 1)
> +			vcpu_hotplug(cpu);
>   	}
>   }
>
>