xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: xen-devel@lists.xensource.com
Subject: [PATCH] linux: small ACPI processor external control code adjustments
Date: Tue, 16 Mar 2010 10:57:28 +0000	[thread overview]
Message-ID: <4B9F722802000078000351D3@vpn.id2.novell.com> (raw)

- don't send a change notification to Xen before having sent an init
  one
- fix a bogus preprocessor directive

Signed-off-by: Jan Beulich <jbeulich@novell.com>

--- a/arch/i386/kernel/acpi/processor_extcntl_xen.c
+++ b/arch/i386/kernel/acpi/processor_extcntl_xen.c
@@ -117,6 +117,8 @@ static int xen_px_notifier(struct acpi_p
 
 	perf = &op.u.set_pminfo.u.perf;
 	px = pr->performance;
+	if (!px)
+		return -EINVAL;
 
 	switch(action) {
 	case PROCESSOR_PM_CHANGE:
--- a/drivers/acpi/processor_perflib.c
+++ b/drivers/acpi/processor_perflib.c
@@ -141,7 +141,7 @@ int acpi_processor_ppc_has_changed(struc
 	else
 #ifdef CONFIG_CPU_FREQ
 		return cpufreq_update_policy(pr->id);
-#elif CONFIG_PROCESSOR_EXTERNAL_CONTROL
+#elif defined(CONFIG_PROCESSOR_EXTERNAL_CONTROL)
 		return processor_notify_external(pr,
 				PROCESSOR_PM_CHANGE, PM_TYPE_PERF);
 #endif

                 reply	other threads:[~2010-03-16 10:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B9F722802000078000351D3@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).