From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] [pv-ops] fix dom0 S3 when MSI is used.
Date: Thu, 18 Mar 2010 18:04:44 -0700
Message-ID: <4BA2CDAC.1010102@goop.org>
References: <4FA716B1526C7C4DB0375C6DADBC4EA342A7A7E95E@LONPMAILBOX01.citrite.net>
	<EADF0A36011179459010BDF5142A457501D11C1BE3@pdsmsx502.ccr.corp.intel.com>
	<4B182D87.6030901@goop.org>
	<EADF0A36011179459010BDF5142A457501D11C20F8@pdsmsx502.ccr.corp.intel.com>
	<4B187513.80003@goop.org>
	<EADF0A36011179459010BDF5142A457501D13FDE62@pdsmsx502.ccr.corp.intel.com>
	<4B200727.8040000@goop.org>
	<1260436078.23698.45463.camel@zakaz.uk.xensource.com>
	<4B2135CC.6000004@goop.org>
	<ED3036A092A28F4C91B0B4360DD128EABDFB4D46@shzsmsx502.ccr.corp.intel.com>
	<20100317142829.GA5861@phenom.dumpdata.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20100317142829.GA5861@phenom.dumpdata.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, "Cui,
	Dexuan" <dexuan.cui@intel.com>
List-Id: xen-devel@lists.xenproject.org

On 03/17/2010 07:28 AM, Konrad Rzeszutek Wilk wrote:
>>   static int msi_free_irqs(struct pci_dev* dev);
>> @@ -347,6 +347,20 @@ static void __pci_restore_msix_state(struct pci_dev *dev)
>>
>>   void pci_restore_msi_state(struct pci_dev *dev)
>>   {
>> +	if (xen_initial_domain()) {
>>      
> That won't do. If you try to compile this kernel on other platforms (say
> PPC), this will throw a huge problem.
>    

Actually, <xen/xen.h> now defines these for all architectures, so 
they're safe to put into arch-independent code.

     J