xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: Bastian Blank <waldi@debian.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
	Keir Fraser <keir.fraser@eu.citrix.com>,
	Xiantao Zhang <xiantao.zhang@intel.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: pvops-2.6.32 - Interrupt routing problem
Date: Tue, 23 Mar 2010 11:37:56 +0000	[thread overview]
Message-ID: <4BA8B62402000078000366E8@vpn.id2.novell.com> (raw)
In-Reply-To: <20100321214723.GA29738@wavehammer.waldi.eu.org>

>>> Bastian Blank <waldi@debian.org> 21.03.10 22:47 >>>
>On Fri, Mar 19, 2010 at 01:13:41PM +0100, Bastian Blank wrote:
>> The real fix could be:
>> - Allow the hypervisor to lock interrupts it uses. Zero would be in it by
>>   default. The interrupt for the used serial interface would be added.
>>   All other pins are free to be programmed by the kernel once.
>> - Don't do register_gsi calls from the initial setup in the kernel if no
>>   ACPI override is present, only setup the rest.
>
>Okay, I think I found another problem. Currently the setup looks like
>this:
>- PHYSDEVOP_setup_gsi: set trigger and polarity, unmask pin

Where are you seeing this? Other than Linux' (unmasking edge
triggered IRQs), Xen's io_apic_set_pci_routing() always masks the
entry afaics.

>- PHYSDEVOP_map_pirq: map to pirq, set irq handler to guest
>
>If an interrupt fires between this two calles, what happens?

Since this is only for edge triggered IRQs, I believe the purpose is
to not lose an edge when first enabling the interrupt. When one
occurs before the handler got set up, the fact that there was one
is just getting latched into desc->status, and the IRQ gets
mask_ack_irq()-ed.

Jan

  parent reply	other threads:[~2010-03-23 11:37 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-10 11:19 pvops-2.6.32 - Interrupt routing problem Bastian Blank
2010-03-10 16:08 ` Ian Campbell
2010-03-10 16:19   ` Bastian Blank
2010-03-10 18:17     ` Jeremy Fitzhardinge
2010-03-10 20:32       ` Bastian Blank
2010-03-10 19:40     ` Ian Campbell
2010-03-10 20:00       ` Konrad Rzeszutek Wilk
2010-03-14 14:08 ` Bastian Blank
2010-03-14 15:23   ` Bastian Blank
2010-03-14 15:56     ` Jeremy Fitzhardinge
2010-03-14 16:17       ` Bastian Blank
2010-03-15  4:30         ` Zhang, Xiantao
2010-03-15 10:11           ` Bastian Blank
2010-03-15 10:36             ` Bastian Blank
2010-03-15 13:48             ` Zhang, Xiantao
2010-03-15 14:18               ` Bastian Blank
2010-03-15 14:38                 ` Zhang, Xiantao
2010-03-15 21:15               ` Bastian Blank
2010-03-16  1:31                 ` Konrad Rzeszutek Wilk
2010-03-16  8:18                   ` Bastian Blank
2010-03-16 15:32                     ` Konrad Rzeszutek Wilk
2010-03-16 18:20                       ` Bastian Blank
2010-03-17  2:05                         ` Konrad Rzeszutek Wilk
2010-03-19 11:39                         ` Bastian Blank
2010-03-19 12:13                           ` Bastian Blank
2010-03-21 21:47                             ` Bastian Blank
2010-03-22  6:24                               ` Jeremy Fitzhardinge
2010-03-23 11:37                               ` Jan Beulich [this message]
2010-03-23 12:37                                 ` Bastian Blank
2010-03-23 14:04                                   ` Jan Beulich
2010-03-23 15:49                                     ` Bastian Blank
2010-03-19 14:15                           ` Zhang, Xiantao
2010-03-19 14:36                             ` Bastian Blank
2010-03-19  2:55                     ` Zhang, Xiantao
2010-03-19 11:06                       ` Bastian Blank
2010-03-14 16:41       ` Bastian Blank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BA8B62402000078000366E8@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=jeremy@goop.org \
    --cc=keir.fraser@eu.citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=waldi@debian.org \
    --cc=xen-devel@lists.xensource.com \
    --cc=xiantao.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).