From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: Xen 4.0.0-rc7 problem/hang with vt-d DMAR parsing Date: Wed, 24 Mar 2010 09:46:37 +0000 Message-ID: <4BA9ED8D0200007800036B3F@vpn.id2.novell.com> References: <20100323193748.GW1878@reaktio.net> <20100323200515.GZ1878@reaktio.net> <4BA9DA400200007800036ABB@vpn.id2.novell.com> <4BA9D512.9090902@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4BA9D512.9090902@intel.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Weidong Han Cc: "xen-devel@lists.xensource.com" , Keir Fraser , Dexuan Cui List-Id: xen-devel@lists.xenproject.org >>> Weidong Han 24.03.10 10:02 >>> >it cannot check entry_header->length < sizeof(struct acpi_table_XXX),=20 >which is not the actual size in acpi table. I don't follow here: Minimally checking against sizeof(struct acpi_dmar_entry_header) should be possible. But I can't even see why checking for sizeof(struct acpi_table_XXX) in the individual case statements can't be done. Jan