From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] x86: fix improper return value from relinquish_memory() Date: Wed, 24 Mar 2010 11:23:32 +0000 Message-ID: <4BAA04440200007800036BBB@vpn.id2.novell.com> References: <4BAA00870200007800036B93@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <4BAA00870200007800036B93@vpn.id2.novell.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> "Jan Beulich" 24.03.10 12:07 >>> >While apparently only a theoretical possibility (domain_kill() has a >BUG_ON() that wasn't reported to trigger so far), I still think it is >better to have the code cleaned up. Btw., the reason I was looking at that code was that we observe zombie domains - ones in DOMDYING_dead state, perhaps having almost none of their memory freed (shadowed guests appear to be particularly bad). In one of the reports, an interesting extra fact was that this happened only for the first 100 guests - any subsequent ones got destroyed properly (obviously to get there this requires quite a bit of memory in the host). Has anyone else observed this? Does this ring any bells? Jan