From: Vincent Hanquez <vincent.hanquez@eu.citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 05/11] libxl: Provide libxl_domain_rename
Date: Fri, 26 Mar 2010 10:01:12 +0000 [thread overview]
Message-ID: <4BAC85E8.3030106@eu.citrix.com> (raw)
In-Reply-To: <1269543854-7780-6-git-send-email-ian.jackson@eu.citrix.com>
On 25/03/10 19:04, Ian Jackson wrote:
> Provide a new function libxl_domain_rename. It can check that the
> domain being renamed has the expected name, to avoid races.
>
> Use the new function to set the name during domain creation.
this looks really ugly (transaction in transaction in domain make), and
has a really complicated code path (which doesn't look right either on
the first read), but
my main objection is that libxl has no business handling the uniqueness
of names or whatever you want to do here. libxl get a name string from
whoever is using it (xl in your case), so if you want somehow to have a
special feature make it so in xl. in other words, no policies in libxl.
also NULL is for pointer, 0 for integer values.
--
Vincent
next prev parent reply other threads:[~2010-03-26 10:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 19:04 [PATCH 00/11] Migration support for "xl" Ian Jackson
2010-03-25 19:04 ` [PATCH 01/11] libxl: Make logging functions preserve errno Ian Jackson
2010-03-25 19:04 ` [PATCH 02/11] libxl: Report error if logfile rotation fails Ian Jackson
2010-03-25 19:04 ` [PATCH 03/11] libxl: New utility functions in for reading and writing files Ian Jackson
2010-03-25 19:04 ` [PATCH 04/11] libxl: libxl_domain_restore: Put fd back to blocking mode Ian Jackson
2010-03-25 19:04 ` [PATCH 05/11] libxl: Provide libxl_domain_rename Ian Jackson
2010-03-26 10:01 ` Vincent Hanquez [this message]
2010-03-26 10:23 ` Ian Jackson
2010-03-26 10:34 ` Vincent Hanquez
2010-03-26 10:40 ` Ian Jackson
2010-04-01 11:00 ` Stefano Stabellini
2010-03-25 19:04 ` [PATCH 06/11] libxl: Expose functions for helping with subprocesses Ian Jackson
2010-03-25 19:04 ` [PATCH 07/11] libxl: Expose libxl_report_exitstatus Ian Jackson
2010-03-25 19:04 ` [PATCH 08/11] libxl: Per-domain data storage for the convenience of the library user Ian Jackson
2010-03-26 10:06 ` Vincent Hanquez
2010-03-26 10:20 ` Ian Jackson
2010-03-26 10:29 ` Vincent Hanquez
2010-03-26 10:34 ` Ian Jackson
2010-03-26 10:41 ` Vincent Hanquez
2010-03-26 10:45 ` Ian Jackson
2010-03-26 11:27 ` Vincent Hanquez
2010-03-26 11:56 ` Ian Jackson
2010-04-01 11:04 ` Stefano Stabellini
2010-03-25 19:04 ` [PATCH 09/11] xl: New savefile format. Save domain config when saving a domain Ian Jackson
2010-04-01 11:08 ` Stefano Stabellini
2010-03-25 19:04 ` [PATCH 10/11] xl: Domain creation logging fixes Ian Jackson
2010-03-25 19:04 ` [PATCH 11/11] xl: Migration support Ian Jackson
2010-04-01 11:10 ` Stefano Stabellini
2010-04-01 11:10 ` [PATCH 00/11] Migration support for "xl" Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAC85E8.3030106@eu.citrix.com \
--to=vincent.hanquez@eu.citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).