From: Vincent Hanquez <vincent.hanquez@eu.citrix.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 05/11] libxl: Provide libxl_domain_rename
Date: Fri, 26 Mar 2010 10:34:43 +0000 [thread overview]
Message-ID: <4BAC8DC3.10309@eu.citrix.com> (raw)
In-Reply-To: <19372.35641.851620.698017@mariner.uk.xensource.com>
On 26/03/10 10:23, Ian Jackson wrote:
> You are confused. The purpose of this check is to check that the
> existing name is as expected, not that the name is not unique
> (although the lack of checking that the name is unique is also a bug).
I'm not confused, there's no need to check anything, libxl is here to
plumb whatever name the user of the library has chosen for its domain
into a xenstore entry: the name is opaque to libxl, and should remains
as such.
if you want some kind of migration lock, put in xl where you define the
policy.
> 0 is a perfectly acceptable null pointer constant.
working != acceptable.
--
Vincent
next prev parent reply other threads:[~2010-03-26 10:34 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 19:04 [PATCH 00/11] Migration support for "xl" Ian Jackson
2010-03-25 19:04 ` [PATCH 01/11] libxl: Make logging functions preserve errno Ian Jackson
2010-03-25 19:04 ` [PATCH 02/11] libxl: Report error if logfile rotation fails Ian Jackson
2010-03-25 19:04 ` [PATCH 03/11] libxl: New utility functions in for reading and writing files Ian Jackson
2010-03-25 19:04 ` [PATCH 04/11] libxl: libxl_domain_restore: Put fd back to blocking mode Ian Jackson
2010-03-25 19:04 ` [PATCH 05/11] libxl: Provide libxl_domain_rename Ian Jackson
2010-03-26 10:01 ` Vincent Hanquez
2010-03-26 10:23 ` Ian Jackson
2010-03-26 10:34 ` Vincent Hanquez [this message]
2010-03-26 10:40 ` Ian Jackson
2010-04-01 11:00 ` Stefano Stabellini
2010-03-25 19:04 ` [PATCH 06/11] libxl: Expose functions for helping with subprocesses Ian Jackson
2010-03-25 19:04 ` [PATCH 07/11] libxl: Expose libxl_report_exitstatus Ian Jackson
2010-03-25 19:04 ` [PATCH 08/11] libxl: Per-domain data storage for the convenience of the library user Ian Jackson
2010-03-26 10:06 ` Vincent Hanquez
2010-03-26 10:20 ` Ian Jackson
2010-03-26 10:29 ` Vincent Hanquez
2010-03-26 10:34 ` Ian Jackson
2010-03-26 10:41 ` Vincent Hanquez
2010-03-26 10:45 ` Ian Jackson
2010-03-26 11:27 ` Vincent Hanquez
2010-03-26 11:56 ` Ian Jackson
2010-04-01 11:04 ` Stefano Stabellini
2010-03-25 19:04 ` [PATCH 09/11] xl: New savefile format. Save domain config when saving a domain Ian Jackson
2010-04-01 11:08 ` Stefano Stabellini
2010-03-25 19:04 ` [PATCH 10/11] xl: Domain creation logging fixes Ian Jackson
2010-03-25 19:04 ` [PATCH 11/11] xl: Migration support Ian Jackson
2010-04-01 11:10 ` Stefano Stabellini
2010-04-01 11:10 ` [PATCH 00/11] Migration support for "xl" Stefano Stabellini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BAC8DC3.10309@eu.citrix.com \
--to=vincent.hanquez@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).