From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vincent Hanquez <vincent.hanquez@eu.citrix.com>
Subject: Re: [PATCH 05/11] libxl: Provide libxl_domain_rename
Date: Fri, 26 Mar 2010 10:34:43 +0000
Message-ID: <4BAC8DC3.10309@eu.citrix.com>
References: <1269543854-7780-1-git-send-email-ian.jackson@eu.citrix.com>	<1269543854-7780-6-git-send-email-ian.jackson@eu.citrix.com>	<4BAC85E8.3030106@eu.citrix.com>
	<19372.35641.851620.698017@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <19372.35641.851620.698017@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

On 26/03/10 10:23, Ian Jackson wrote:
> You are confused.  The purpose of this check is to check that the
> existing name is as expected, not that the name is not unique
> (although the lack of checking that the name is unique is also a bug).

I'm not confused, there's no need to check anything, libxl is here to 
plumb whatever name the user of the library has chosen for its domain 
into a xenstore entry: the name is opaque to libxl, and should remains 
as such.

if you want some kind of migration lock, put in xl where you define the 
policy.

> 0 is a perfectly acceptable null pointer constant.

working != acceptable.

-- 
Vincent