From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Subject: Re: [PATCH 03/11] [XEN] NUMA guest tools interface Date: Wed, 7 Apr 2010 14:13:22 +0200 Message-ID: <4BBC76E2.9020603@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dulloor Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Dulloor wrote: > The patch adds hypercall interfaces to get/set the virtual numa layout > for a domain. I don't see the need for introducing this many new interfaces. I couldn't find a reference for the nodemap information (mfn_to_nid) to be actually used somewhere, is there any missing part or was it just for the sake of completeness? Beside that, cpu_to_node is already in physinfo, and via xc_availheap (which takes a node parameter) you can query the amount of free memory per node. I think that is all we need to know about the host's NUMA topology, but correct me if I am wrong. (OK, the distance information is missing...) From a design point of view I would avoid exporting so many host machine information to Dom0 unless we really need it. Regards, Andre. -- Andre Przywara AMD-Operating System Research Center (OSRC), Dresden, Germany Tel: +49 351 448-3567-12