From: Yu Zhiguo <yuzg@cn.fujitsu.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi
Date: Tue, 20 Apr 2010 13:31:23 +0800 [thread overview]
Message-ID: <4BCD3C2B.3030706@cn.fujitsu.com> (raw)
In-Reply-To: <20100419133026.GA17501@phenom.dumpdata.com>
Hi, Konrad
Konrad Rzeszutek Wilk wrote:
>
> perhaps add:
>
> #else /* This is for CONFIG_XEN */
>
> static inline int xen_register_gsi(...)
> {
>
> }
> #endif
>
> Or maybe better take out the xen_register_gsi out of this double
> #ifdef and move it to its own. Say:
>
>
> #if !defined(CONFIG_XEN)
> static int xen_register_gsi(..)
>
> #endif
>
>
>>> ...
>>>
>> This is a good way of handling it.
>
> The header file change or the #ifdef in the acpi/boot.c file?
Thanks for your explanation, I agree it is also a good idea.
But if jeremy think adding #ifdef is ok, I will not fix this patch.
--
Regards
Yu Zhiguo
next prev parent reply other threads:[~2010-04-20 5:31 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 2:07 [PATCH] pv-ops: Fix missing 'ifdef CONFIG_XEN' in acpi Yu Zhiguo
2010-04-16 14:56 ` Konrad Rzeszutek Wilk
2010-04-18 3:56 ` Yu Zhiguo
2010-04-18 4:46 ` Jeremy Fitzhardinge
2010-04-19 13:30 ` Konrad Rzeszutek Wilk
2010-04-19 16:22 ` Jeremy Fitzhardinge
2010-04-20 5:31 ` Yu Zhiguo [this message]
2010-04-20 18:33 ` Konrad Rzeszutek Wilk
2010-04-21 3:29 ` Yu Zhiguo
2010-04-21 13:00 ` Konrad Rzeszutek Wilk
2010-04-21 13:53 ` Yu Zhiguo
2010-04-21 16:33 ` Jeremy Fitzhardinge
2010-04-22 4:05 ` Yu Zhiguo
2010-04-22 16:27 ` Jeremy Fitzhardinge
2010-04-25 4:24 ` Yu Zhiguo
2010-04-21 16:31 ` Jeremy Fitzhardinge
2010-04-19 11:23 ` Failure to load the most recent kernel 2.6.10 ( xen/stable) under Xen 4.0 on Ubuntu 9.10 Boris Derzhavets
2010-04-20 10:44 ` Failure to load the most recent kernel 2.6.32.10 " Boris Derzhavets
2010-04-20 12:46 ` Boris Derzhavets
2010-04-20 18:21 ` Jeremy Fitzhardinge
2010-04-20 21:25 ` Boris Derzhavets
2010-04-21 8:05 ` Yu, Ke
2010-04-21 12:19 ` Boris Derzhavets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BCD3C2B.3030706@cn.fujitsu.com \
--to=yuzg@cn.fujitsu.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).