From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yu Zhiguo Subject: xl: Fix segment fault of 'xl list' Date: Mon, 26 Apr 2010 13:08:07 +0800 Message-ID: <4BD51FB7.2000504@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org If libxl_list_domain() returns NULL, segment fault occurs now. Signed-off-by: Yu Zhiguo diff -r c87ec146229a -r 5727e3c71513 tools/libxl/xl.c --- a/tools/libxl/xl.c Fri Apr 23 15:04:26 2010 +0100 +++ b/tools/libxl/xl.c Mon Apr 26 21:07:19 2010 +0800 @@ -1521,7 +1521,7 @@ info = libxl_list_domain(&ctx, &nb_domain); - if (info < 0) { + if (!info) { fprintf(stderr, "libxl_domain_infolist failed.\n"); exit(1); }