From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH 6 of 6] PV on HVM suspend\resume
Date: Mon, 26 Apr 2010 12:03:11 -0700
Message-ID: <4BD5E36F.80204@goop.org>
References: <alpine.DEB.2.00.1004221610060.11380@kaball-desktop>
	<4BD22888.1060305@goop.org>
	<alpine.DEB.2.00.1004260022580.11380@kaball-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <alpine.DEB.2.00.1004260022580.11380@kaball-desktop>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Ian Campbell <Ian.Campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 04/25/2010 04:25 PM, Stefano Stabellini wrote:
>> This won't compile with CONFIG_PREEMPT enabled, because out_destroy_sm
>> is missing below.
>>
>>     
>  
> Now it is fixed,

Did you push out the fix (ideally as a new delta changeset on top of the
previous ones, rather than rebaseing them).


>  however I tried suspend/resume with CONFIG_PREEMPT
> enabled and the kernel seems to hang at resume time; I wonder if it
> works for pv guests since the suspend/resume code is similiar...
>   

I think Pasi and IanC tested it quite a bit not too long ago, but its
possible they didn't test preempt kernels (and it wouldn't surprise me
at all if preempt breaks things).

Thanks,
    J