* [PATCH] libxl: make set_memory_target work on domains with no videoram
@ 2010-04-30 23:04 Jeremy Fitzhardinge
2010-05-01 8:49 ` Vincent Hanquez
0 siblings, 1 reply; 2+ messages in thread
From: Jeremy Fitzhardinge @ 2010-04-30 23:04 UTC (permalink / raw)
To: Stefano Stabellini; +Cc: Ian Jackson, Xen-devel, Vincent Hanquez
If a domain has no videoram (say, dom0), then treat the size as 0 and
continue, rather than just failing.
Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
diff -r 0ea790d96997 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c Fri Apr 30 14:46:55 2010 -0700
+++ b/tools/libxl/libxl.c Fri Apr 30 15:59:25 2010 -0700
@@ -2292,9 +2292,10 @@
char *dompath = libxl_xs_get_dompath(ctx, domid);
videoram_s = libxl_xs_read(ctx, XBT_NULL, libxl_sprintf(ctx, "%s/memory/videoram", dompath));
- if (!videoram_s)
- return -1;
- videoram = atoi(videoram_s);
+ if (videoram_s)
+ videoram = atoi(videoram_s);
+ else
+ videoram = 0;
libxl_xs_write(ctx, XBT_NULL, libxl_sprintf(ctx, "%s/memory/target", dompath), "%lu", target_memkb);
rc = xc_domain_setmaxmem(ctx->xch, domid, target_memkb + LIBXL_MAXMEM_CONSTANT);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] libxl: make set_memory_target work on domains with no videoram
2010-04-30 23:04 [PATCH] libxl: make set_memory_target work on domains with no videoram Jeremy Fitzhardinge
@ 2010-05-01 8:49 ` Vincent Hanquez
0 siblings, 0 replies; 2+ messages in thread
From: Vincent Hanquez @ 2010-05-01 8:49 UTC (permalink / raw)
To: Jeremy Fitzhardinge; +Cc: Xen-devel, Ian Jackson, Stefano Stabellini
On 01/05/10 00:04, Jeremy Fitzhardinge wrote:
> If a domain has no videoram (say, dom0), then treat the size as 0 and
> continue, rather than just failing.
>
> Signed-off-by: Jeremy Fitzhardinge<jeremy.fitzhardinge@citrix.com>
>
Acked-by: Vincent Hanquez <vincent.hanquez@eu.citrix.com>
Thanks Jeremy,
--
Vincent
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-01 8:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-04-30 23:04 [PATCH] libxl: make set_memory_target work on domains with no videoram Jeremy Fitzhardinge
2010-05-01 8:49 ` Vincent Hanquez
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).