From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frank Van Der Linden Subject: Re: RE: [PATCH] x86: add CMCI software injection interface Date: Tue, 04 May 2010 21:52:11 -0600 Message-ID: <4BE0EB6B.6090804@oracle.com> References: <789F9655DD1B8F43B48D77C5D30659731D8B3C40@shsmsx501.ccr.corp.intel.com> <789F9655DD1B8F43B48D77C5D30659731E41783E@shsmsx501.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <789F9655DD1B8F43B48D77C5D30659731E41783E@shsmsx501.ccr.corp.intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "Ke, Liping" Cc: Egger , "xen-devel@lists.xensource.com" , "gavin.maltby@oracle.com" , "Jiang, Yunhong" , Christoph@rcsinet11.oracle.com, Keir Fraser List-Id: xen-devel@lists.xenproject.org On 5/4/10 7:56 PM, Ke, Liping wrote: > Hi, Keir > > Yes, we do some discussion about the interface compatibility problem before submitting. > But we found the mceinj_cpunr below is defined as unsigned int (not uint32), so we think it may have some problem in 32/64 bit machine originally. > So we gave up the backward compatibility effort and made it as uint32_5. But if sun/oracle use this interface before, we did have some problem > > So Christopher and Gavin, any suggestions for this? > > Regards, > criping I have no problems with this change. dom0/Xen should match in version anyway. There have been ABI breakages in the dom0/Xen interface before. You can bump the xen MCE hypercall version if you wish.. - Frank