From: "Jan Beulich" <JBeulich@novell.com>
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH, v2] reduce 'd' debug key's global impact
Date: Thu, 06 May 2010 10:25:45 +0100 [thread overview]
Message-ID: <4BE2A73902000078000018A0@vpn.id2.novell.com> (raw)
In-Reply-To: <C8084727.1363B%keir.fraser@eu.citrix.com>
>>> Keir Fraser <keir.fraser@eu.citrix.com> 06.05.10 11:15 >>>
>On 06/05/2010 10:07, "Jan Beulich" <JBeulich@novell.com> wrote:
>> Otoh it seems like I will should add irq_enter()/irq_exit() now that the
>> function calls something non-trivial...
>
>Yes, most definitely. They are cheap and should be added unconditionally to
>the handler if you go this route.
Hmm, smp_call_function_interrupt() for example also doesn't do this
unconditionally, so I'd prefer having them only in the unlikely code
path.
Jan
next prev parent reply other threads:[~2010-05-06 9:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 15:34 [PATCH, v2] reduce 'd' debug key's global impact Jan Beulich
2010-05-06 6:46 ` Jan Beulich
2010-05-06 7:42 ` Keir Fraser
2010-05-06 8:01 ` Keir Fraser
2010-05-06 8:14 ` Jan Beulich
2010-05-06 9:05 ` Keir Fraser
2010-05-06 9:07 ` Jan Beulich
2010-05-06 9:15 ` Keir Fraser
2010-05-06 9:25 ` Jan Beulich [this message]
2010-05-06 9:37 ` Keir Fraser
2010-05-06 8:07 ` Jan Beulich
2010-05-06 9:09 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BE2A73902000078000018A0@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=keir.fraser@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).