xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Jim Fehlig <JFEHLIG@novell.com>,
	xen-devel@lists.xensource.com, James Song <JSong@novell.com>
Subject: Re: [PATCH 2/2] reap the blktapctl thread and notify the tapdisk backend driver to release resource like memory..
Date: Mon, 10 May 2010 08:06:54 +0100	[thread overview]
Message-ID: <4BE7CCAE0200007800001FDA@vpn.id2.novell.com> (raw)
In-Reply-To: <19428.20126.27164.576006@mariner.uk.xensource.com>

>>> Ian Jackson <Ian.Jackson@eu.citrix.com> 07.05.10 19:32 >>>
>In fact however there is allegedly some bug somewhere which this patch
>is supposed to deal with, but I can't really see the connection.

The bug was with the blktap kernel driver not being able to clean up
after an unclean exit of qemu. We had reports of this only for 3.4
and 4.0 (and I wonder how no-one else noticed this, when the bug
was introduced about a year ago, even before blktap2 got added),
yet the problematic blktap code also existed in those systems that
we ship with 3.2.3 and 3.3.1, hence either no-one ever noticed the
problem on those platforms, or there must be a behavioral
difference of qemu (i.e. cleaning up after itself in earlier versions).

I fully agree that the kernel should (or really has to) properly clean
up after any uncleanly exiting application, yet ...

>I think in general we should be aiming for crash-only software.
>  http://dslab.epfl.ch/pubs/crashonly/crashonly.pdf 
>It's much much more reliable, as well as meaning we need to write less
>code (and thus fewer bugs).

... I can see a philosophical point in this discussion (but I don't
agree that this is the only sensible position).

Jan

  reply	other threads:[~2010-05-10  7:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-05  3:22 [PATCH 2/2] reap the blktapctl thread and notify the tapdisk backend driver to release resource like memory James Song
2010-05-06 16:01 ` Ian Jackson
2010-05-07  7:20   ` Jan Beulich
2010-05-07 17:32     ` Ian Jackson
2010-05-10  7:06       ` Jan Beulich [this message]
2010-05-10 11:30         ` Ian Jackson
2010-05-10 12:10           ` Keir Fraser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BE7CCAE0200007800001FDA@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=Ian.Jackson@eu.citrix.com \
    --cc=JFEHLIG@novell.com \
    --cc=JSong@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).