From: Yang Hongyang <yanghy@cn.fujitsu.com>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH]xl: Add missing start_time entry when create and restore VMs
Date: Sat, 15 May 2010 09:54:23 +0800 [thread overview]
Message-ID: <4BEDFECF.9090408@cn.fujitsu.com> (raw)
In-Reply-To: <181d8804-a9f0-4707-a2bc-514132a13c29@default>
On 05/14/2010 11:47 PM, Dan Magenheimer wrote:
>> + vments[5] = libxl_sprintf(ctx, "%lu.%d", start_time.tv_sec,(int)start_time.tv_usec/10000);
>> + vments[i++] = libxl_sprintf(ctx, "%lu.%d",start_time.tv_sec,(int)start_time.tv_usec/10000);
>
> I don't think these work as intended. For example, if
> tv_usec is 10000, I think you want xxx.01 printed, not
> xxx.1. Maybe you want %lu.%02d?
Ah sorry, you're right, I'll fix that, Thank you.
>
> And in any case, is there a reason to limit the precision
> to two digits? Why not %lu.%06d?
>
I see no reason too. But the current start_time is limit to
two digits(vms created from 'xm create'). So I limit the
precision to two digits.
>
--
Regards
Yang Hongyang
next prev parent reply other threads:[~2010-05-15 1:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 11:33 [PATCH]xl: Add missing start_time entry when create and restore VMs Yang Hongyang
2010-05-14 15:47 ` Dan Magenheimer
2010-05-15 1:54 ` Yang Hongyang [this message]
2010-05-15 2:06 ` [PATCH v2]xl: " Yang Hongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BEDFECF.9090408@cn.fujitsu.com \
--to=yanghy@cn.fujitsu.com \
--cc=dan.magenheimer@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).