xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Add MSR support for new AMD processor families
Date: Mon, 17 May 2010 09:32:55 +0100	[thread overview]
Message-ID: <4BF11B57020000780000305A@vpn.id2.novell.com> (raw)
In-Reply-To: <201005141419.02047.mark.langsdorf@amd.com>

>>> Mark Langsdorf <mark.langsdorf@amd.com> 14.05.10 21:19 >>>
>@@ -500,7 +499,7 @@
> #endif
> 
> 	/* Pointless to use MWAIT on Family10 as it does not deep sleep. */
>-	if (c->x86 == 0x10 && !force_mwait)
>+	if (c->x86 >= 0x10 && !force_mwait)
> 		clear_bit(X86_FEATURE_MWAIT, c->x86_capability);
> 
> 	/* K6s reports MCEs but don't actually have all the MSRs */

Is this indeed the right thing to do on *all* processors starting
with Fam10?

Jan

      reply	other threads:[~2010-05-17  8:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-14 19:19 [PATCH] Add MSR support for new AMD processor families Mark Langsdorf
2010-05-17  8:32 ` Jan Beulich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BF11B57020000780000305A@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=mark.langsdorf@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).