From: Yang Hongyang <yanghy@cn.fujitsu.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Cc: Dan Magenheimer <dan.magenheimer@oracle.com>,
Keir Fraser <keir.fraser@eu.citrix.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: [PATCH 5/6]xl: Add 'xl tmem-set' command
Date: Wed, 19 May 2010 16:33:57 +0800 [thread overview]
Message-ID: <4BF3A275.40309@cn.fujitsu.com> (raw)
In-Reply-To: <4BF39FB9.3050005@cn.fujitsu.com>
Add 'xl tmem-set' command
Signed-off-by: Yang Hongyang<yanghy@cn.fujitsu.com>
diff -r f5c579127b26 tools/libxl/libxl.c
--- a/tools/libxl/libxl.c Wed May 19 23:35:17 2010 +0800
+++ b/tools/libxl/libxl.c Wed May 19 23:37:09 2010 +0800
@@ -2885,3 +2885,35 @@
return rc;
}
+
+static int32_t tmem_setop_from_string(char *set_name)
+{
+ if (!strcmp(set_name, "weight"))
+ return TMEMC_SET_WEIGHT;
+ else if (!strcmp(set_name, "cap"))
+ return TMEMC_SET_CAP;
+ else if (!strcmp(set_name, "compress"))
+ return TMEMC_SET_COMPRESS;
+ else
+ return -1;
+}
+
+int libxl_tmem_set(struct libxl_ctx *ctx, uint32_t domid, char* name, uint32_t set)
+{
+ int rc;
+ int32_t subop = tmem_setop_from_string(name);
+
+ if (subop == -1) {
+ XL_LOG_ERRNOVAL(ctx, XL_LOG_ERROR, -1,
+ "Invalid set, valid sets are <weight|cap|compress>");
+ return -1;
+ }
+ rc = xc_tmem_control(ctx->xch, -1, subop, domid, set, 0, 0, NULL);
+ if (rc < 0) {
+ XL_LOG_ERRNOVAL(ctx, XL_LOG_ERROR, rc,
+ "Can not set tmem %s", name);
+ return -1;
+ }
+
+ return rc;
+}
diff -r f5c579127b26 tools/libxl/libxl.h
--- a/tools/libxl/libxl.h Wed May 19 23:35:17 2010 +0800
+++ b/tools/libxl/libxl.h Wed May 19 23:37:09 2010 +0800
@@ -517,5 +517,7 @@
int libxl_tmem_freeze(struct libxl_ctx *ctx, uint32_t domid);
int libxl_tmem_destroy(struct libxl_ctx *ctx, uint32_t domid);
int libxl_tmem_thaw(struct libxl_ctx *ctx, uint32_t domid);
+int libxl_tmem_set(struct libxl_ctx *ctx, uint32_t domid, char* name,
+ uint32_t set);
#endif /* LIBXL_H */
diff -r f5c579127b26 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c Wed May 19 23:35:17 2010 +0800
+++ b/tools/libxl/xl_cmdimpl.c Wed May 19 23:37:09 2010 +0800
@@ -3822,3 +3822,64 @@
exit(0);
}
+int main_tmem_set(int argc, char **argv)
+{
+ char *dom = NULL;
+ uint32_t weight = 0, cap = 0, compress = 0;
+ int opt_w = 0, opt_c = 0, opt_p = 0;
+ int all = 0;
+ int opt;
+
+ while ((opt = getopt(argc, argv, "aw:c:p:h")) != -1) {
+ switch (opt) {
+ case 'a':
+ all = 1;
+ break;
+ case 'w':
+ weight = strtol(optarg, NULL, 10);
+ opt_w = 1;
+ break;
+ case 'c':
+ cap = strtol(optarg, NULL, 10);
+ opt_c = 1;
+ break;
+ case 'p':
+ compress = strtol(optarg, NULL, 10);
+ opt_p = 1;
+ break;
+ case 'h':
+ help("tmem-set");
+ exit(0);
+ default:
+ fprintf(stderr, "option `%c' not supported.\n", opt);
+ break;
+ }
+ }
+
+ dom = argv[optind];
+ if (!dom && all == 0) {
+ fprintf(stderr, "You must specify -a or a domain id.\n\n");
+ help("tmem-set");
+ exit(1);
+ }
+
+ if (all)
+ domid = -1;
+ else
+ find_domain(dom);
+
+ if (!opt_w && !opt_c && !opt_p) {
+ fprintf(stderr, "No set value specified.\n\n");
+ help("tmem-set");
+ exit(1);
+ }
+
+ if (opt_w)
+ libxl_tmem_set(&ctx, domid, "weight", weight);
+ if (opt_c)
+ libxl_tmem_set(&ctx, domid, "cap", cap);
+ if (opt_p)
+ libxl_tmem_set(&ctx, domid, "compress", compress);
+
+ exit(0);
+}
diff -r f5c579127b26 tools/libxl/xl_cmdimpl.h
--- a/tools/libxl/xl_cmdimpl.h Wed May 19 23:35:17 2010 +0800
+++ b/tools/libxl/xl_cmdimpl.h Wed May 19 23:37:09 2010 +0800
@@ -56,6 +56,7 @@
int main_tmem_freeze(int argc, char **argv);
int main_tmem_destroy(int argc, char **argv);
int main_tmem_thaw(int argc, char **argv);
+int main_tmem_set(int argc, char **argv);
void help(char *command);
diff -r f5c579127b26 tools/libxl/xl_cmdtable.c
--- a/tools/libxl/xl_cmdtable.c Wed May 19 23:35:17 2010 +0800
+++ b/tools/libxl/xl_cmdtable.c Wed May 19 23:37:09 2010 +0800
@@ -248,6 +248,15 @@
"[<Domain>|-a]",
" -a Thaw all tmem",
},
+ { "tmem-set",
+ &main_tmem_set,
+ "Change tmem settings",
+ "[<Domain>|-a] [-w[=WEIGHT]|-c[=CAP]|-p[=COMPRESS]]",
+ " -a Operate on all tmem\n"
+ " -w WEIGHT Weight (int)\n"
+ " -c CAP Cap (int)\n"
+ " -p COMPRESS Compress (int)",
+ },
};
int cmdtable_len = sizeof(cmd_table)/sizeof(struct cmd_spec);
--
Regards
Yang Hongyang
next prev parent reply other threads:[~2010-05-19 8:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 8:22 [PATCH 0/6]xl: Add 'xl tmem-*' commands Yang Hongyang
2010-05-19 8:26 ` [PATCH 1/6]xl: Add 'xl tmem-list' command Yang Hongyang
2010-05-19 8:29 ` [PATCH 2/6]xl: Add 'xl tmem-freeze' command Yang Hongyang
2010-05-19 8:31 ` [PATCH 3/6]xl: Add 'xl tmem-destroy' command Yang Hongyang
2010-05-19 8:32 ` [PATCH 4/6]xl: Add 'xl tmem-thaw' command Yang Hongyang
2010-05-19 8:33 ` Yang Hongyang [this message]
2010-05-19 8:35 ` [PATCH 6/6]xl: Add 'xl tmem-shared-auth' command Yang Hongyang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BF3A275.40309@cn.fujitsu.com \
--to=yanghy@cn.fujitsu.com \
--cc=dan.magenheimer@oracle.com \
--cc=keir.fraser@eu.citrix.com \
--cc=stefano.stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).