From: Jeremy Fitzhardinge <jeremy@goop.org>
To: James Harper <james.harper@bendigoit.com.au>
Cc: Bastian Blank <waldi@debian.org>, xen-devel@lists.xensource.com
Subject: Re: Null-pointer access in netback_uevent
Date: Fri, 28 May 2010 16:30:48 -0700 [thread overview]
Message-ID: <4C005228.5060107@goop.org> (raw)
In-Reply-To: <AEC6C66638C05B468B556EA548C1A77D01996C1F@trantor>
On 05/28/2010 03:42 PM, James Harper wrote:
>>>> Looking into this further, I suspect that the trigger here is a newer
>>>> version of udev or something in that area. netback_uevent is getting called
>>>> before the call to netback_probe containing the call to dev_set_drvdata.
>>>>
>>>>
>>> There are two problems there. And yes, the uevent routine can be called
>>> at any time.
>>>
>>>
>> So would it be correct for it to just return if either of those are
>> NULL?
>>
> Not sure. It works though.
>
Can you send me a properly signed-off patch?
Thanks,
J
next prev parent reply other threads:[~2010-05-28 23:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-27 16:55 Null-pointer access in netback_uevent Bastian Blank
2010-05-27 21:03 ` Jeremy Fitzhardinge
2010-05-27 22:27 ` Bastian Blank
2010-05-27 22:39 ` Jeremy Fitzhardinge
2010-05-27 23:02 ` Bastian Blank
2010-05-28 0:04 ` James Harper
2010-05-28 0:33 ` James Harper
2010-05-28 0:47 ` James Harper
2010-05-28 9:03 ` Bastian Blank
2010-05-28 17:28 ` Jeremy Fitzhardinge
2010-05-28 22:42 ` James Harper
2010-05-28 23:30 ` Jeremy Fitzhardinge [this message]
2010-05-28 23:59 ` James Harper
2010-05-29 6:44 ` Bastian Blank
2010-05-29 18:44 ` [PATCH] xen/netback: Fix null-pointer " Bastian Blank
2010-05-31 7:37 ` Jan Beulich
2010-05-31 8:07 ` Jan Beulich
2010-07-28 16:20 ` Bastian Blank
2010-07-29 11:47 ` Ian Campbell
2010-07-29 12:42 ` Bastian Blank
2010-07-29 13:44 ` Ian Campbell
2010-07-29 13:48 ` Ian Campbell
2010-07-29 15:30 ` Bastian Blank
2010-07-29 15:40 ` Jeremy Fitzhardinge
2010-07-29 17:08 ` Bastian Blank
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C005228.5060107@goop.org \
--to=jeremy@goop.org \
--cc=james.harper@bendigoit.com.au \
--cc=waldi@debian.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).