From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gihan Munasinghe <GMunasinghe@flexiant.com>
Subject: Re: syslog support to xentoollog
Date: Thu, 03 Jun 2010 15:31:56 +0100
Message-ID: <4C07BCDC.8020808@flexiant.com>
References: <4C06CF97.8070002@flexiant.com>
	<alpine.DEB.2.00.1006031121020.3401@kaball-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <alpine.DEB.2.00.1006031121020.3401@kaball-desktop>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Stefano Stabellini wrote:
> On Wed, 2 Jun 2010, Gihan Munasinghe wrote:
>   
>> Guys
>>
>> Is there any plans to add syslog support in to xentoollog.
>>
>> Is this something that xentoollog would like to adopt .
>>
>>     
>
> That is something we definitely want, patches are welcome :-)
>
>   
Great I'll do some patching to get syslog working.

looking at the xentool.h, following definitions

#define XTL_STDIOSTREAM_SHOW_PID      01u
#define XTL_STDIOSTREAM_SHOW_DATE     02u
#define XTL_STDIOSTREAM_HIDE_PROGRESS 04u

I would suggest to be as
#define XTL_SHOW_PID      01u
#define XTL_SHOW_DATE     02u
#define XTL_HIDE_PROGRESS 04u
So it will be more generic for any loggers that will be implemented

also is everyone happy with following loglevel mappings between 
xentoollog_level and syslog

        {XTL_DEBUG,LOG_DEBUG},
        {XTL_VERBOSE,LOG_DEBUG},
        {XTL_DETAIL,LOG_DEBUG},
        {XTL_PROGRESS,LOG_DEBUG},
        {XTL_INFO,LOG_INFO},
        {XTL_NOTICE,LOG_NOTICE},
        {XTL_WARN,LOG_WARNING},
        {XTL_ERROR,LOG_ERR},
        {XTL_CRITICAL,LOG_CRIT}

Thanks
Gihan