From: Gihan Munasinghe <GMunasinghe@flexiant.com>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
Subject: Re: [PATCH] syslog support to xentoollog
Date: Mon, 07 Jun 2010 12:37:16 +0100 [thread overview]
Message-ID: <4C0CD9EC.8090705@flexiant.com> (raw)
In-Reply-To: <19468.52155.98452.875297@mariner.uk.xensource.com>
Ian Jackson wrote:
> Gihan Munasinghe writes ("[PATCH] syslog support to xentoollog"):
>
>> Also could someone look @ the syslogger_progress function and add any
>> extra bits if needed, I did a very basic implementation of this.
>>
>
> I think it should at the very least limit the messages until the
> percentage changes by at least (say) 5%. The progress function may be
> called very very often.
>
>
Is this the only change that need to happen, are you happy with the rest
of the patch.
Tanks
Gihan
next prev parent reply other threads:[~2010-06-07 11:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 21:39 syslog support to xentoollog Gihan Munasinghe
2010-06-03 10:21 ` Stefano Stabellini
2010-06-03 14:31 ` Gihan Munasinghe
2010-06-04 11:25 ` Ian Jackson
2010-06-05 0:51 ` [PATCH] " Gihan Munasinghe
2010-06-07 6:51 ` Keir Fraser
2010-06-07 10:37 ` Ian Jackson
2010-06-07 10:33 ` Ian Jackson
2010-06-07 11:36 ` Gihan Munasinghe
2010-06-07 11:51 ` Ian Jackson
2010-06-07 10:36 ` Ian Jackson
2010-06-07 11:37 ` Gihan Munasinghe [this message]
2010-06-07 11:51 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C0CD9EC.8090705@flexiant.com \
--to=gmunasinghe@flexiant.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).