xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Michal Novotny <minovotn@redhat.com>
To: xen-devel@lists.xensource.com
Subject: Re: [PATCH] qemu-xen-3.4-testing: Fix read-only image file handling
Date: Mon, 07 Jun 2010 15:10:24 +0200	[thread overview]
Message-ID: <4C0CEFC0.5040506@redhat.com> (raw)
In-Reply-To: <20100607114538.GC17817@reaktio.net>

On 06/07/2010 01:45 PM, Pasi Kärkkäinen wrote:
> On Mon, Jun 07, 2010 at 01:21:21PM +0200, Michal Novotny wrote:
>    
>> Well, I'm still having some tools issues, mainly:
>>
>> Error: (111, 'Connection refused')
>>
>> Any guess what may be going wrong? Booted grub entry:
>>
>> title Red Hat Enterprise Linux Server (2.6.31.13-xen HV, nolog)
>>          root (hd1,6)
>>          kernel /xen-4.1-unstable.gz
>>          module /vmlinuz-2.6.31.13 ro root=LABEL=/rhel2 rhgb quiet selinux=0
>>          module /initrd-2.6.31.13.img
>>
>> Mount is having `xenfs on /proc/xen type xenfs (rw)`. Any guess what may
>> be going wrong?
>>
>>      
>
> Do you have xen-evtchn driver loaded?
>
>
> -- Pasi
>
>    

Well, no, and doesn't seem to be installed/probed:

# modprobe xen-evtchn
# lsmod | grep xen-evtchn
#

So there's the problem :(

Michal

>    
>> Thanks,
>> Michal
>>
>> On 06/04/2010 12:42 PM, Pasi Kärkkäinen wrote:
>>      
>>> On Fri, Jun 04, 2010 at 11:37:51AM +0200, Michal Novotny wrote:
>>>
>>>        
>>>> Oh, one more thing I've discovered now. Since the codebase for
>>>> qemu-xen-unstable is looking the same like for qemu-xen-3.4-testing and
>>>> the patch is applicable without any modifications it could be working
>>>> for xen-4.1 unstable as well, unfortunately I was not able to boot PVOPS
>>>> kernel since it always ends up in kernel panic, maybe the missing
>>>> drivers or something like that.
>>>>
>>>>
>>>>          
>>> What kernel version? Did you use xen/stable-2.6.32.x branch from xen.git?
>>>
>>> See my example .config files from:
>>> http://wiki.xensource.com/xenwiki/XenParavirtOps in the "troubleshooting" section.
>>>
>>> Works on F12/F13 dom0's.
>>>
>>> For el5 dom0 you might need these:
>>> http://wiki.xensource.com/xenwiki/2.6.18-to-2.6.31-and-higher
>>>
>>> aka
>>> CONFIG_SYSFS_DEPRECATED=y
>>> CONFIG_SYSFS_DEPRECATED_V2=y
>>>
>>> Also atm I think you need CONFIG_XEN_XENBUS_FRONTEND=y in the .config
>>> because of the recently added pv-on-hvm drivers (you'll get build failure without that option),
>>> so you need XEN_PCIDEV_FRONTEND XEN_BLKDEV_FRONTEND or XEN_NETDEV_FRONTEND or XEN_FBDEV_FRONTEND needs to be =y.
>>>
>>> -- Pasi
>>>
>>>
>>>
>>>        
>>>> On 06/03/2010 04:12 PM, Michal Novotny wrote:
>>>>
>>>>          
>>>>> Oh, just one more thing that should be mentioned:
>>>>>
>>>>> When you want to mount an image that is set as read-only in the domain
>>>>> configuration file but you omit to set mode to read-only it results
>>>>> into I/O errors when processing the requests. Remounting as read-only
>>>>> or unmounting and remounting using the `mount /dev/* /path/to/mount -o
>>>>> ro` shall do the mounting the correct way, i.e. with no I/O errors, so
>>>>> make sure you mount those disks as read-only otherwise you can be
>>>>> getting errors like:
>>>>>
>>>>> end_request: I/O error, dev hdb, sector 52
>>>>>
>>>>> Buffer I/O error on device hdb1, logical block 1
>>>>>
>>>>> lost page write due to I/O error on hdb1
>>>>>
>>>>>
>>>>> and for IDE devices you'll be getting several additional DeviceFault
>>>>> errors since mounting the device read-write (default setting) writes
>>>>> some data onto a disk at the mount-time.
>>>>>
>>>>> Michal
>>>>>
>>>>> On 06/03/2010 04:04 PM, Michal Novotny wrote:
>>>>>
>>>>>            
>>>>>> [Well, I did send an e-mail to the list using git but it's not here
>>>>>> so I'm forwarding the e-mail to the list for sure:]
>>>>>>
>>>>>> Hi,
>>>>>> this is the patch for qemu-xen-3.4-testing to fix the read-only
>>>>>> image file handling since the image file was always treated as
>>>>>> read-write which means that all the HVM guests were able to
>>>>>> write to all the disk images available in domain configuration
>>>>>> file no matter what the mode of the image was defined. This
>>>>>> patch fixes this functionality to honor the O_RDONLY in the
>>>>>> BDRV_O_ACCESS flag in block.c and also fixes the IDE and SCSI
>>>>>> interfaces that uses it.
>>>>>>
>>>>>> It's been tested on RHEL-5 with xen-3.4-testing version of
>>>>>> upstream xen with xen-3.4-testing qemu implementation.
>>>>>>
>>>>>> For SCSI devices the DATA PROTECT request sense has been added
>>>>>> as found at: http://en.wikipedia.org/wiki/SCSI_Request_Sense_Command
>>>>>>
>>>>>> file no matter what the mode of the image was defined. This
>>>>>> patch fixes this functionality to honor the O_RDONLY in the
>>>>>> BDRV_O_ACCESS flag in block.c and also fixes the IDE and SCSI
>>>>>> interfaces that uses it.
>>>>>>
>>>>>> It's been tested on RHEL-5 with xen-3.4-testing version of
>>>>>> Michal
>>>>>>
>>>>>> Signed-off-by: Michal Novotny<minovotn@redhat.com>
>>>>>>
>>>>>>
>>>>>> _______________________________________________
>>>>>> Xen-devel mailing list
>>>>>> Xen-devel@lists.xensource.com
>>>>>> http://lists.xensource.com/xen-devel
>>>>>>
>>>>>>              
>>>>>
>>>>>            
>>>> -- 
>>>> Michal Novotny<minovotn@redhat.com>, RHCE
>>>> Virtualization Team (xen userspace), Red Hat
>>>>
>>>>
>>>> _______________________________________________
>>>> Xen-devel mailing list
>>>> Xen-devel@lists.xensource.com
>>>> http://lists.xensource.com/xen-devel
>>>>
>>>>          
>>
>> -- 
>> Michal Novotny<minovotn@redhat.com>, RHCE
>> Virtualization Team (xen userspace), Red Hat
>>
>>      
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>    


-- 
Michal Novotny<minovotn@redhat.com>, RHCE
Virtualization Team (xen userspace), Red Hat

  reply	other threads:[~2010-06-07 13:10 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-03 14:04 [PATCH] qemu-xen-3.4-testing: Fix read-only image file handling Michal Novotny
2010-06-03 14:12 ` Michal Novotny
2010-06-04  9:37   ` Michal Novotny
2010-06-04 10:42     ` Pasi Kärkkäinen
2010-06-04 10:57       ` Michal Novotny
2010-06-04 13:00         ` Michal Novotny
2010-06-04 13:11           ` Keir Fraser
2010-06-04 13:12           ` Pasi Kärkkäinen
2010-06-07 11:21       ` Michal Novotny
2010-06-07 11:39         ` Keir Fraser
2010-06-07 13:09           ` Michal Novotny
2010-06-07 13:14             ` Pasi Kärkkäinen
2010-06-07 18:24             ` Jeremy Fitzhardinge
2010-06-07 11:45         ` Pasi Kärkkäinen
2010-06-07 13:10           ` Michal Novotny [this message]
2010-06-07 13:14             ` Michal Novotny
2010-06-07 13:19               ` Pasi Kärkkäinen
2010-06-07 13:21                 ` Michal Novotny
2010-06-07 13:25                   ` Michal Novotny
2010-06-07 13:36                     ` Michal Novotny
2010-06-07 13:46                       ` Keir Fraser
2010-06-07 15:00                         ` Michal Novotny
2010-06-07 15:17                           ` M A Young
2010-06-07 15:28                             ` Michal Novotny
2010-06-07 14:56                       ` Pasi Kärkkäinen
2010-06-07 15:02                         ` Michal Novotny
2010-06-07 16:12                       ` Konrad Rzeszutek Wilk
2010-06-07 16:27                         ` Michal Novotny
2010-06-07 16:34                           ` Keir Fraser
2010-06-07 16:37                             ` Michal Novotny
2010-06-07 17:56                               ` Keir Fraser
2010-06-08 10:04                                 ` Michal Novotny
2010-06-08 10:39                                   ` Michal Novotny
2010-06-08 10:50                                     ` Keir Fraser
2010-06-08 10:52                                       ` Michal Novotny
2010-06-08 11:03                                         ` Keir Fraser
2010-06-08 11:06                                           ` Michal Novotny
2010-06-08 10:53                                   ` Keir Fraser
2010-06-08 10:54                                     ` Michal Novotny
2010-06-08 11:11                                     ` M A Young
2010-06-08 11:15                                       ` Michal Novotny
2010-06-07 14:06                     ` Pasi Kärkkäinen
2010-06-07 13:25             ` M A Young
     [not found] <C82EBB27.16AFC%keir.fraser@eu.citrix.com>
2010-06-04 13:45 ` Michal Novotny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C0CEFC0.5040506@redhat.com \
    --to=minovotn@redhat.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).