[PATCH] x86: return value of domain_pirq_to_irq() is signed

[PATCH] x86: return value of domain_pirq_to_irq() is signed

[Jan Beulich]

[-- Attachment #1: Type: text/plain, Size: 938 bytes --]

That value can, for forcibly unbound PIRQs, validly be negative, and
for the respective check to catch those cases (and prevent using these
negative values as array index), the respective variables must be of
signed type.

Signed-off-by: Jan Beulich <jbeulich@novell.com>

--- 2010-06-15.orig/xen/arch/x86/irq.c	2010-06-15 09:21:05.000000000 +0200
+++ 2010-06-15/xen/arch/x86/irq.c	2010-06-15 13:23:00.000000000 +0200
@@ -887,7 +887,7 @@ static void __do_IRQ_guest(int irq)
 struct irq_desc *domain_spin_lock_irq_desc(
     struct domain *d, int pirq, unsigned long *pflags)
 {
-    unsigned int irq;
+    int irq;
     unsigned long flags;
     struct irq_desc *desc;
 
@@ -1054,7 +1054,7 @@ extern int ioapic_ack_new;
 static int pirq_acktype(struct domain *d, int pirq)
 {
     struct irq_desc  *desc;
-    unsigned int irq;
+    int irq;
 
     irq = domain_pirq_to_irq(d, pirq);
     if ( irq <= 0 )




[-- Attachment #2: x86-signed-domain-irq.patch --]
[-- Type: text/plain, Size: 932 bytes --]

That value can, for forcibly unbound PIRQs, validly be negative, and
for the respective check to catch those cases (and prevent using these
negative values as array index), the respective variables must be of
signed type.

Signed-off-by: Jan Beulich <jbeulich@novell.com>

--- 2010-06-15.orig/xen/arch/x86/irq.c	2010-06-15 09:21:05.000000000 +0200
+++ 2010-06-15/xen/arch/x86/irq.c	2010-06-15 13:23:00.000000000 +0200
@@ -887,7 +887,7 @@ static void __do_IRQ_guest(int irq)
 struct irq_desc *domain_spin_lock_irq_desc(
     struct domain *d, int pirq, unsigned long *pflags)
 {
-    unsigned int irq;
+    int irq;
     unsigned long flags;
     struct irq_desc *desc;
 
@@ -1054,7 +1054,7 @@ extern int ioapic_ack_new;
 static int pirq_acktype(struct domain *d, int pirq)
 {
     struct irq_desc  *desc;
-    unsigned int irq;
+    int irq;
 
     irq = domain_pirq_to_irq(d, pirq);
     if ( irq <= 0 )

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel