From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@novell.com>
Subject: Re: [PATCH] x86: fix pv cpuid masking
Date: Wed, 16 Jun 2010 14:21:03 +0100
Message-ID: <4C18EBDF0200007800006AF8@vpn.id2.novell.com>
References: <4C1784F8020000780000677C@vpn.id2.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <4C1784F8020000780000677C@vpn.id2.novell.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

>>> On 15.06.10 at 13:49, "Jan Beulich" <JBeulich@novell.com> wrote:
> Invert initial values of the variables parsed into from the command
> line, so that completely clearing out one or more of the four bit
> fields is possible.
>=20
> Further, consolidate the command line parameter specifications into
> a single place.
>=20
> Finally, as per "Intel Virtualization Technology FlexMigration
> Application Note" (http://www.intel.com/Assets/PDF/manual/323850.pdf),
> also handle family 6 model 0x1f.
>=20
> What remains open is the question whether pv_cpuid() shouldn't also
> consume these masks.

What is your opinion on this, Keir?

Jan