From: "Jan Beulich" <JBeulich@novell.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Cris Daniluk <cris.daniluk@gmail.com>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
Keir Fraser <keir.fraser@eu.citrix.com>,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: Xen 4.0 crashes with pvops kernel
Date: Wed, 16 Jun 2010 15:36:24 +0100 [thread overview]
Message-ID: <4C18FD880200007800006B5F@vpn.id2.novell.com> (raw)
In-Reply-To: <20100615151534.GB4901@phenom.dumpdata.com>
>>> On 15.06.10 at 17:15, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
>> >>> Dom0 to map the IO-APIC space read-only? Perhaps even
> .. snip
>> Actually, that's a difference to non-pv-ops that I strongly
>> believe should be fixed: While in the traditional kernel
>> __direct_remap_pfn_range() is used to establish I/O memory
>> mappings (and hence there is a way to propagate errors), the
>> pv-ops kernel appears to use ioremap_page_range() - just like
>> native - which can only return -ENOMEM (upon page table
>> allocation failure), due to the lack of a return value from
>> set_pte_at().
>>
>> But then again I must be missing something here, since
>> xen_set_pte_at() falls back to xen_set_pte() if the hypercall
>> it tries first fails, and that one would fault when establishing
>> the mapping, not when trying to first use it. Jeremy?
>
> Take a look at xen_set_fixmap, which I think is used for most of those
> special addresses. It is mapped to a null-space for the IO APIC
> addresses.
I don't think that code matters here: execution goes through
acpi_os_map_memory(), and at the time the problem talked
about here happens I think the ioremap() in there ought to
be taken.
Jan
next prev parent reply other threads:[~2010-06-16 14:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-14 22:10 Xen 4.0 crashes with pvops kernel Cris Daniluk
2010-06-15 6:54 ` Jan Beulich
[not found] ` <AANLkTimslcbXQnihpIB0c-ceWbD7H-eyUY_BV2igyfzv@mail.gmail.com>
2010-06-15 12:50 ` Jan Beulich
2010-06-15 12:56 ` Keir Fraser
2010-06-15 13:20 ` Jan Beulich
2010-06-15 13:24 ` Cris Daniluk
2010-06-15 13:43 ` Jan Beulich
2010-06-15 13:49 ` Cris Daniluk
2010-06-15 14:13 ` Jan Beulich
2010-06-15 14:35 ` Cris Daniluk
2010-06-15 14:58 ` Jan Beulich
2010-06-15 15:01 ` Cris Daniluk
2010-06-15 15:21 ` Jan Beulich
2010-06-15 16:18 ` Boris Derzhavets
2010-06-15 14:17 ` Pasi Kärkkäinen
2010-06-15 15:11 ` Konrad Rzeszutek Wilk
2010-06-16 14:42 ` Jan Beulich
2010-06-15 13:57 ` Jan Beulich
2010-06-15 15:15 ` Konrad Rzeszutek Wilk
2010-06-16 14:36 ` Jan Beulich [this message]
2010-06-24 9:29 ` Jeremy Fitzhardinge
2010-06-24 11:30 ` Jan Beulich
2010-06-24 21:25 ` Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C18FD880200007800006B5F@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=cris.daniluk@gmail.com \
--cc=jeremy@goop.org \
--cc=keir.fraser@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).