From: Michal Novotny <minovotn@redhat.com>
To: "Pasi Kärkkäinen" <pasik@iki.fi>
Cc: admin@dmarkey.com, xen-devel@lists.xensource.com
Subject: Re: XCP: pygrub missing ext4 support.
Date: Mon, 21 Jun 2010 15:02:23 +0200 [thread overview]
Message-ID: <4C1F62DF.3010408@redhat.com> (raw)
In-Reply-To: <20100621124426.GK17817@reaktio.net>
On 06/21/2010 02:44 PM, Pasi Kärkkäinen wrote:
> On Mon, Jun 21, 2010 at 01:58:35PM +0200, Michal Novotny wrote:
>
>> David, this is totally xen independent thing. This is based on the
>> operating system's version of e2fsprogs installed and provided if there
>> are systems having e2fsprogs version *with* the ext4 support it will be
>> working fine for them.
>>
>>
> Michal: Remember we're talking about XCP (Xen Cloud Platform) here,
> not "traditional" Xen installations..
>
> So it just needs to be decided in which way to solve it in XCP.
>
> -- Pasi
>
>
Oh, sorry Pasi, I didn't know that. If this is about XCP (which I am
completely unfamiliar with) it's fine. Just note that it the e2fsprogs
on the host machine does matter so maybe having the newest e2fsprogs in
the XCP should work fine.
Michal
>> Michal
>>
>> On 06/21/2010 01:55 PM, David Markey wrote:
>>
>>> Well whichever way we go, could we get some movement before XCP 0.5 final?
>>>
>>> On 21 June 2010 12:48, Michal Novotny<minovotn@redhat.com
>>> <mailto:minovotn@redhat.com>> wrote:
>>>
>>> On 06/21/2010 01:38 PM, David Markey wrote:
>>>
>>> The *non-e2fsprogs* implementation, i.e.
>>> tools/libfsimage/ext2fs/fsys_ext2fs.c has ext4 support already.
>>>
>>>
>>> Oh, ok, provided the fact that e2fsprogs implementation is being
>>> just simply linked to the e2fsprogs library upgrading the package
>>> to the newest/upstream package is the simplest thing you could do.
>>>
>>> Michal
>>>
>>>
>>>
>>> On 21 June 2010 12:29, Michal Novotny<minovotn@redhat.com
>>> <mailto:minovotn@redhat.com> <mailto:minovotn@redhat.com
>>> <mailto:minovotn@redhat.com>>> wrote:
>>>
>>> On 06/21/2010 01:26 PM, David Markey wrote:
>>>
>>> Well, which ever way we do it, either using the built in
>>> libfsimage ext4 support, or upgrading e2fsprogs, we should
>>> choose one?
>>>
>>>
>>>
>>> Well, when using libfsimage *non-e2fsprogs* implementation the
>>> ext4 support have to be added manually but when using e2fsprogs
>>> implementation (i.e. the version linked with e2fsprogs) I
>>> recommend upgrading your version of e2fsprogs to the
>>> newest/upstream version.
>>>
>>> Michal
>>>
>>> On 21 June 2010 10:59, Michal Novotny
>>> <minovotn@redhat.com<mailto:minovotn@redhat.com>
>>> <mailto:minovotn@redhat.com<mailto:minovotn@redhat.com>>
>>> <mailto:minovotn@redhat.com<mailto:minovotn@redhat.com>
>>>
>>> <mailto:minovotn@redhat.com<mailto:minovotn@redhat.com>>>> wrote:
>>>
>>> On 06/19/2010 06:07 PM, Pasi Kärkkäinen wrote:
>>>
>>> On Sat, Jun 19, 2010 at 05:00:57PM +0100, David
>>> Markey
>>> wrote:
>>>
>>> XCP pygrub should have ext4 support.
>>> It currently doesn't because the libfsimage
>>> ext2fs-lib
>>> module is linked
>>> against libext2fs, which doesnt have ext4
>>> support in XCP.
>>> Instead, XCP should use the ext2fs module
>>> that comes
>>> with libfsimage,
>>> which has ext4 support.
>>> Most new releases of distributions has it
>>> as their
>>> default filesystem.
>>> Most notably, Ubuntu 10.04
>>>
>>>
>>> Also Fedora 12, Fedora 13, upcoming Debian 6.0
>>> ("Squeeze") and
>>> RHEL6.
>>>
>>> -- Pasi
>>>
>>>
>>> Well, this is not the Xen issue here. We're having this
>>> fixed in
>>> RHEL-5 by simply reinstalling the e2fsprogs package
>>> to the
>>> latest
>>> one, although in case of RHEL-5 it's been renamed to
>>> e4fsprogs.
>>> The simplest thing you can do about this is to
>>> reinstall the
>>> e2fsprogs package on the host machine and it will be
>>> working fine
>>> - at least it was when I did test it on RHEL-5 some
>>> time ago.
>>>
>>> Simply put, reinstalling the e2fsprogs to the latest
>>> version will
>>> do the job and allow ext4 functionality to pygrub.
>>>
>>> Michal
>>>
>>>
>>>
>>> An easy way for the build to use ext2fs
>>> instead of
>>> ext2fs-lib, is to not
>>> have ext2fs/ext2fs.h present.
>>> Alternatively this patch hard codes it.
>>> (From 4.0)
>>> --- a/tools/libfsimage/Makefile
>>> 2010-06-19
>>> 16:52:04.231221516
>>> +0100
>>> +++ b/tools/libfsimage/Makefile
>>> 2010-06-19
>>> 16:52:08.803250922
>>> +0100
>>> @@ -1,8 +1,7 @@
>>> XEN_ROOT = ../..
>>> include $(XEN_ROOT)/tools/Rules.mk
>>>
>>> -SUBDIRS-y = common ufs reiserfs iso9660
>>> fat zfs
>>> -SUBDIRS-y += $(shell env CC="$(CC)"
>>> ./check-libext2fs)
>>> +SUBDIRS-y = common ufs reiserfs iso9660
>>> fat zfs
>>> ext2fs
>>>
>>> .PHONY: all clean install
>>> all clean install: %: subdirs-%
>>>
>>>
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@lists.xensource.com
>>> <mailto:Xen-devel@lists.xensource.com>
>>> <mailto:Xen-devel@lists.xensource.com
>>> <mailto:Xen-devel@lists.xensource.com>>
>>> <mailto:Xen-devel@lists.xensource.com
>>> <mailto:Xen-devel@lists.xensource.com>
>>> <mailto:Xen-devel@lists.xensource.com
>>> <mailto:Xen-devel@lists.xensource.com>>>
>>>
>>> http://lists.xensource.com/xen-devel
>>>
>>>
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@lists.xensource.com
>>> <mailto:Xen-devel@lists.xensource.com>
>>> <mailto:Xen-devel@lists.xensource.com
>>> <mailto:Xen-devel@lists.xensource.com>>
>>> <mailto:Xen-devel@lists.xensource.com
>>> <mailto:Xen-devel@lists.xensource.com>
>>> <mailto:Xen-devel@lists.xensource.com
>>> <mailto:Xen-devel@lists.xensource.com>>>
>>>
>>> http://lists.xensource.com/xen-devel
>>>
>>>
>>>
>>> -- Michal Novotny<minovotn@redhat.com
>>> <mailto:minovotn@redhat.com>
>>> <mailto:minovotn@redhat.com<mailto:minovotn@redhat.com>>
>>> <mailto:minovotn@redhat.com<mailto:minovotn@redhat.com>
>>>
>>> <mailto:minovotn@redhat.com<mailto:minovotn@redhat.com>>>>, RHCE
>>>
>>> Virtualization Team (xen userspace), Red Hat
>>>
>>>
>>>
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@lists.xensource.com
>>> <mailto:Xen-devel@lists.xensource.com>
>>> <mailto:Xen-devel@lists.xensource.com
>>> <mailto:Xen-devel@lists.xensource.com>>
>>> <mailto:Xen-devel@lists.xensource.com
>>> <mailto:Xen-devel@lists.xensource.com>
>>> <mailto:Xen-devel@lists.xensource.com
>>> <mailto:Xen-devel@lists.xensource.com>>>
>>>
>>> http://lists.xensource.com/xen-devel
>>>
>>>
>>>
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@lists.xensource.com
>>> <mailto:Xen-devel@lists.xensource.com>
>>> <mailto:Xen-devel@lists.xensource.com
>>> <mailto:Xen-devel@lists.xensource.com>>
>>> http://lists.xensource.com/xen-devel
>>>
>>>
>>>
>>> -- Michal Novotny<minovotn@redhat.com
>>> <mailto:minovotn@redhat.com> <mailto:minovotn@redhat.com
>>> <mailto:minovotn@redhat.com>>>, RHCE
>>> Virtualization Team (xen userspace), Red Hat
>>>
>>>
>>>
>>>
>>> -- Michal Novotny<minovotn@redhat.com
>>> <mailto:minovotn@redhat.com>>, RHCE
>>> Virtualization Team (xen userspace), Red Hat
>>>
>>>
>>>
>>> _______________________________________________
>>> Xen-devel mailing list
>>> Xen-devel@lists.xensource.com
>>> http://lists.xensource.com/xen-devel
>>>
>>>
>>
>> --
>> Michal Novotny<minovotn@redhat.com>, RHCE
>> Virtualization Team (xen userspace), Red Hat
>>
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xensource.com
>> http://lists.xensource.com/xen-devel
>>
--
Michal Novotny<minovotn@redhat.com>, RHCE
Virtualization Team (xen userspace), Red Hat
prev parent reply other threads:[~2010-06-21 13:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-19 16:00 XCP: pygrub missing ext4 support David Markey
2010-06-19 16:07 ` Pasi Kärkkäinen
2010-06-21 9:59 ` Michal Novotny
2010-06-21 11:26 ` David Markey
2010-06-21 11:29 ` Michal Novotny
2010-06-21 11:38 ` David Markey
2010-06-21 11:48 ` Michal Novotny
2010-06-21 11:55 ` David Markey
2010-06-21 11:58 ` Michal Novotny
2010-06-21 12:44 ` Pasi Kärkkäinen
2010-06-21 13:02 ` Michal Novotny [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1F62DF.3010408@redhat.com \
--to=minovotn@redhat.com \
--cc=admin@dmarkey.com \
--cc=pasik@iki.fi \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).