From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Novotny Subject: Re: XCP: pygrub missing ext4 support. Date: Mon, 21 Jun 2010 15:02:23 +0200 Message-ID: <4C1F62DF.3010408@redhat.com> References: <20100619160714.GN17817@reaktio.net> <4C1F37E7.5030500@redhat.com> <4C1F4CFE.7040806@redhat.com> <4C1F51A5.7020301@redhat.com> <4C1F53EB.5020700@redhat.com> <20100621124426.GK17817@reaktio.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20100621124426.GK17817@reaktio.net> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: =?ISO-8859-1?Q?Pasi_K=E4rkk=E4inen?= Cc: admin@dmarkey.com, xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 06/21/2010 02:44 PM, Pasi K=E4rkk=E4inen wrote: > On Mon, Jun 21, 2010 at 01:58:35PM +0200, Michal Novotny wrote: > =20 >> David, this is totally xen independent thing. This is based on the >> operating system's version of e2fsprogs installed and provided if ther= e >> are systems having e2fsprogs version *with* the ext4 support it will b= e >> working fine for them. >> >> =20 > Michal: Remember we're talking about XCP (Xen Cloud Platform) here, > not "traditional" Xen installations.. > > So it just needs to be decided in which way to solve it in XCP. > > -- Pasi > > =20 Oh, sorry Pasi, I didn't know that. If this is about XCP (which I am=20 completely unfamiliar with) it's fine. Just note that it the e2fsprogs=20 on the host machine does matter so maybe having the newest e2fsprogs in=20 the XCP should work fine. Michal >> Michal >> >> On 06/21/2010 01:55 PM, David Markey wrote: >> =20 >>> Well whichever way we go, could we get some movement before XCP 0.5 f= inal? >>> >>> On 21 June 2010 12:48, Michal Novotny>> > wrote: >>> >>> On 06/21/2010 01:38 PM, David Markey wrote: >>> >>> The *non-e2fsprogs* implementation, i.e. >>> tools/libfsimage/ext2fs/fsys_ext2fs.c has ext4 support alrea= dy. >>> >>> >>> Oh, ok, provided the fact that e2fsprogs implementation is being >>> just simply linked to the e2fsprogs library upgrading the packag= e >>> to the newest/upstream package is the simplest thing you could d= o. >>> >>> Michal >>> >>> >>> >>> On 21 June 2010 12:29, Michal Novotny>> >> >> wrote: >>> >>> On 06/21/2010 01:26 PM, David Markey wrote: >>> >>> Well, which ever way we do it, either using the built= in >>> libfsimage ext4 support, or upgrading e2fsprogs, we s= hould >>> choose one? >>> >>> >>> >>> Well, when using libfsimage *non-e2fsprogs* implementatio= n the >>> ext4 support have to be added manually but when using e2f= sprogs >>> implementation (i.e. the version linked with e2fsprogs) I >>> recommend upgrading your version of e2fsprogs to the >>> newest/upstream version. >>> >>> Michal >>> >>> On 21 June 2010 10:59, Michal Novotny >>> >>> > >>> >>> >>> >>> = wrote: >>> >>> On 06/19/2010 06:07 PM, Pasi K=E4rkk=E4inen wrote: >>> >>> On Sat, Jun 19, 2010 at 05:00:57PM +0100, Davi= d >>> Markey >>> wrote: >>> >>> XCP pygrub should have ext4 support. >>> It currently doesn't because the libfsi= mage >>> ext2fs-lib >>> module is linked >>> against libext2fs, which doesnt have ex= t4 >>> support in XCP. >>> Instead, XCP should use the ext2fs modu= le >>> that comes >>> with libfsimage, >>> which has ext4 support. >>> Most new releases of distributions has = it >>> as their >>> default filesystem. >>> Most notably, Ubuntu 10.04 >>> >>> >>> Also Fedora 12, Fedora 13, upcoming Debian 6.0 >>> ("Squeeze") and >>> RHEL6. >>> >>> -- Pasi >>> >>> >>> Well, this is not the Xen issue here. We're having= this >>> fixed in >>> RHEL-5 by simply reinstalling the e2fsprogs packag= e >>> to the >>> latest >>> one, although in case of RHEL-5 it's been renamed = to >>> e4fsprogs. >>> The simplest thing you can do about this is to >>> reinstall the >>> e2fsprogs package on the host machine and it will = be >>> working fine >>> - at least it was when I did test it on RHEL-5 som= e >>> time ago. >>> >>> Simply put, reinstalling the e2fsprogs to the late= st >>> version will >>> do the job and allow ext4 functionality to pygrub. >>> >>> Michal >>> >>> >>> >>> An easy way for the build to use ext2fs >>> instead of >>> ext2fs-lib, is to not >>> have ext2fs/ext2fs.h present. >>> Alternatively this patch hard codes it. >>> (From 4.0) >>> --- a/tools/libfsimage/Makefile >>> 2010-06-19 >>> 16:52:04.231221516 >>> +0100 >>> +++ b/tools/libfsimage/Makefile >>> 2010-06-19 >>> 16:52:08.803250922 >>> +0100 >>> @@ -1,8 +1,7 @@ >>> XEN_ROOT =3D ../.. >>> include $(XEN_ROOT)/tools/Rules.mk >>> >>> -SUBDIRS-y =3D common ufs reiserfs iso9= 660 >>> fat zfs >>> -SUBDIRS-y +=3D $(shell env CC=3D"$(CC)= " >>> ./check-libext2fs) >>> +SUBDIRS-y =3D common ufs reiserfs iso9= 660 >>> fat zfs >>> ext2fs >>> >>> .PHONY: all clean install >>> all clean install: %: subdirs-% >>> >>> >>> __________________________________________= _____ >>> Xen-devel mailing list >>> Xen-devel@lists.xensource.com >>> >>> >> > >>> >> >>> >> >> >>> >>> http://lists.xensource.com/xen-devel >>> >>> >>> ______________________________________________= _ >>> Xen-devel mailing list >>> Xen-devel@lists.xensource.com >>> >>> >> > >>> >> >>> >> >> >>> >>> http://lists.xensource.com/xen-devel >>> >>> >>> >>> -- Michal Novotny>> >>> > >>> >>> >>> >>>, = RHCE >>> >>> Virtualization Team (xen userspace), Red Hat >>> >>> >>> >>> _______________________________________________ >>> Xen-devel mailing list >>> Xen-devel@lists.xensource.com >>> >>> >> > >>> >> >>> >> >> >>> >>> http://lists.xensource.com/xen-devel >>> >>> >>> >>> _______________________________________________ >>> Xen-devel mailing list >>> Xen-devel@lists.xensource.com >>> >>> >> > >>> http://lists.xensource.com/xen-devel >>> >>> >>> >>> -- Michal Novotny>> >> >>, RHCE >>> Virtualization Team (xen userspace), Red Hat >>> >>> >>> >>> >>> -- Michal Novotny>> >, RHCE >>> Virtualization Team (xen userspace), Red Hat >>> >>> >>> >>> _______________________________________________ >>> Xen-devel mailing list >>> Xen-devel@lists.xensource.com >>> http://lists.xensource.com/xen-devel >>> >>> =20 >> >> --=20 >> Michal Novotny, RHCE >> Virtualization Team (xen userspace), Red Hat >> >> >> _______________________________________________ >> Xen-devel mailing list >> Xen-devel@lists.xensource.com >> http://lists.xensource.com/xen-devel >> =20 --=20 Michal Novotny, RHCE Virtualization Team (xen userspace), Red Hat