From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Novotny Subject: Re: Re: Xen-unstable save error Date: Tue, 22 Jun 2010 12:05:51 +0200 Message-ID: <4C208AFF.3000304@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: "xen-devel@lists.xensource.com" , Jan Beulich List-Id: xen-devel@lists.xenproject.org On 06/22/2010 12:01 PM, Keir Fraser wrote: > On 22/06/2010 07:48, "Jan Beulich" wrote: > > >>>>> On 22.06.10 at 08:23, Michal Novotny wrote: >>>>> >>> Jan, as we were solving this with Keir on the list I was unable to save >>> the HVM guest properly and reverting your c/s 21615 helped and with your >>> patch reverted it was working fine. Any idea why there were so type >>> failures for all the pages of HVM guest? >>> >> Not really, and I think you will need to find out by instrumenting the >> hypercall implementation (XEN_DOMCTL_getpageframeinfo{2,3}) - >> really, type failures should only happen for grant frames and I/O >> memory pages (as you can see in the code, for the function to >> report XTAB either the MFN must be invalid, must be a Xen frame, >> or it must be impossible to obtain a reference to the page - all of >> which shouldn't hold for the majority of a HVM guest's pages). >> > Michal, is it possible you are running new tools against a slightly older > hypervisor? The tools changes had a corresponding, non-version-checked, > modification to a hypercall. Without running the modified hypervisor, HVM > save would indeed behave very oddly! > > -- Keir > > > Keir, I don't think so since the hypervisor datetime in /boot is the same like for kernel and tools. Michal -- Michal Novotny, RHCE Virtualization Team (xen userspace), Red Hat