From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Novotny Subject: Re: [PATCH] Fix restore handling checks Date: Wed, 23 Jun 2010 11:59:51 +0200 Message-ID: <4C21DB17.3060800@redhat.com> References: <4C205583.80609@redhat.com 4C20B2F8.4030409@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Dan Magenheimer Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 06/22/2010 10:46 PM, Dan Magenheimer wrote: > Correct me if I am wrong, but I think your patch assumes > that the amount of free memory in the system can be > computed by assuming each guest memory is fixed size. > Due to various features in Xen 4.0, this is no longer > a safe assumption. Tmem has a libxc call to freeze > and unfreeze its use of memory so dynamic memory use > by tmem can be stopped, and another libxc call to > determine "freeable" memory, and another to free it. > I don't know if the page-sharing functionality added > at 4.0 has anything similar. > > Honestly I don't know about how tmem features work since I have them disabled because I'm unable to start any guest with them enabled because it fails on creation. Michal -- Michal Novotny, RHCE Virtualization Team (xen userspace), Red Hat