xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: John Haxby <john.haxby@oracle.com>
To: xen-devel@lists.xensource.com
Subject: Xen 3.4.x and request-abs-pointer
Date: Mon, 05 Jul 2010 16:22:48 +0100	[thread overview]
Message-ID: <4C31F8C8.8090800@oracle.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 329 bytes --]

A little while ago Jeremy Fitzhardinge was having some problem with 
absolute pointers.  This turned out to be a very simple fix in qemu-xen: 
wait for the frontend to be connected before connecting the backend.  
I've attached that original patch, if there's going to be a xen-3.4.4 it 
would be nice if this was included.

jch

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 1037 bytes --]

commit 805ed3b20492d2f4bb465bfda65cedd286e23209
Author: Ian Jackson <ian.jackson@eu.citrix.com>
Date:   Fri May 21 15:46:55 2010 +0100

    Wait for frontend state Connected before connecting the backend
    
    The frontend of the framebuffer set a value (request-abs-pointer) and go
    to the state Connected.  The backend must read this value only when the
    frontend has the state Connected.
    
    From: Anthony PERARD <anthony.perard@citrix.com>
    Tested-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>

diff --git a/hw/xen_backend.c b/hw/xen_backend.c
index 76d07ec..31ed7b0 100644
--- a/hw/xen_backend.c
+++ b/hw/xen_backend.c
@@ -411,8 +411,7 @@ static int xen_be_try_connect(struct XenDevice *xendev)
 {
     int rc = 0;
 
-    if (xendev->fe_state != XenbusStateInitialised  &&
-	xendev->fe_state != XenbusStateConnected) {
+    if (xendev->fe_state != XenbusStateConnected) {
 	if (xendev->ops->flags & DEVOPS_FLAG_IGNORE_STATE) {
 	    xen_be_printf(xendev, 2, "frontend not ready, ignoring\n");
 	} else {

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2010-07-05 15:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-05 15:22 John Haxby [this message]
2010-07-05 15:45 ` Xen 3.4.x and request-abs-pointer Stefano Stabellini
2010-07-05 16:27   ` John Haxby
2010-07-05 16:41     ` Stefano Stabellini
2010-07-06  8:19       ` John Haxby

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C31F8C8.8090800@oracle.com \
    --to=john.haxby@oracle.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).