xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Jan Beulich" <JBeulich@novell.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: [PATCH] linux: pci/guestdev: cleanup data definitions
Date: Fri, 09 Jul 2010 10:08:43 +0100	[thread overview]
Message-ID: <4C37033B020000780000A6E4@vpn.id2.novell.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 623 bytes --]

Keep a local variable from polluting the global namespace, and move
another one into .init.data since it's only being used by __init
functions.

Signed-off-by: Jan Beulich <jbeulich@novell.com>

--- a/drivers/pci/guestdev.c
+++ b/drivers/pci/guestdev.c
@@ -81,8 +81,8 @@ struct pcidev_sbdf_node {
 
 static int reassign_resources = 0;
 
-static char guestdev_param[COMMAND_LINE_SIZE];
-LIST_HEAD(guestdev_list);
+static char __initdata guestdev_param[COMMAND_LINE_SIZE];
+static LIST_HEAD(guestdev_list);
 
 /* Get hid and uid */
 static int __init pci_get_hid_uid(char *str, char *hid, char *uid)




[-- Attachment #2: xenlinux-pci-guestdev-decls.patch --]
[-- Type: text/plain, Size: 668 bytes --]

Subject: pci/guestdev: cleanup data definitions

Keep a local variable from polluting the global namespace, and move
another one into .init.data since it's only being used by __init
functions.

Signed-off-by: Jan Beulich <jbeulich@novell.com>

--- a/drivers/pci/guestdev.c
+++ b/drivers/pci/guestdev.c
@@ -81,8 +81,8 @@ struct pcidev_sbdf_node {
 
 static int reassign_resources = 0;
 
-static char guestdev_param[COMMAND_LINE_SIZE];
-LIST_HEAD(guestdev_list);
+static char __initdata guestdev_param[COMMAND_LINE_SIZE];
+static LIST_HEAD(guestdev_list);
 
 /* Get hid and uid */
 static int __init pci_get_hid_uid(char *str, char *hid, char *uid)

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

                 reply	other threads:[~2010-07-09  9:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C37033B020000780000A6E4@vpn.id2.novell.com \
    --to=jbeulich@novell.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).