From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: [PATCH] linux: pci/guestdev: cleanup data definitions Date: Fri, 09 Jul 2010 10:08:43 +0100 Message-ID: <4C37033B020000780000A6E4@vpn.id2.novell.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=__PartFED3890B.0__=" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: "xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org This is a MIME message. If you are reading this text, you may want to consider changing to a mail reader or gateway that understands how to properly handle MIME multipart messages. --=__PartFED3890B.0__= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Keep a local variable from polluting the global namespace, and move another one into .init.data since it's only being used by __init functions. Signed-off-by: Jan Beulich --- a/drivers/pci/guestdev.c +++ b/drivers/pci/guestdev.c @@ -81,8 +81,8 @@ struct pcidev_sbdf_node { =20 static int reassign_resources =3D 0; =20 -static char guestdev_param[COMMAND_LINE_SIZE]; -LIST_HEAD(guestdev_list); +static char __initdata guestdev_param[COMMAND_LINE_SIZE]; +static LIST_HEAD(guestdev_list); =20 /* Get hid and uid */ static int __init pci_get_hid_uid(char *str, char *hid, char *uid) --=__PartFED3890B.0__= Content-Type: text/plain; name="xenlinux-pci-guestdev-decls.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="xenlinux-pci-guestdev-decls.patch" Subject: pci/guestdev: cleanup data definitions=0A=0AKeep a local variable = from polluting the global namespace, and move=0Aanother one into .init.data= since it's only being used by __init=0Afunctions.=0A=0ASigned-off-by: Jan = Beulich =0A=0A--- a/drivers/pci/guestdev.c=0A+++ = b/drivers/pci/guestdev.c=0A@@ -81,8 +81,8 @@ struct pcidev_sbdf_node {=0A = =0A static int reassign_resources =3D 0;=0A =0A-static char guestdev_param[= COMMAND_LINE_SIZE];=0A-LIST_HEAD(guestdev_list);=0A+static char __initdata = guestdev_param[COMMAND_LINE_SIZE];=0A+static LIST_HEAD(guestdev_list);=0A = =0A /* Get hid and uid */=0A static int __init pci_get_hid_uid(char *str, = char *hid, char *uid)=0A --=__PartFED3890B.0__= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --=__PartFED3890B.0__=--