From: "Jan Beulich" <JBeulich@novell.com>
To: Tim Deegan <Tim.Deegan@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: Re: [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records
Date: Fri, 09 Jul 2010 17:02:16 +0100 [thread overview]
Message-ID: <4C376428020000780000A8B7@vpn.id2.novell.com> (raw)
In-Reply-To: <20100709150741.GF31695@whitby.uk.xensource.com>
>>> On 09.07.10 at 17:07, Tim Deegan <Tim.Deegan@citrix.com> wrote:
> At 15:44 +0100 on 09 Jul (1278690260), Jan Beulich wrote:
>> >>> On 09.07.10 at 15:30, Tim Deegan <Tim.Deegan@citrix.com> wrote:
>> >+ if ( tr.extra_bytes > 28 || tr.event >= 0x1000 )
>>
>> Couldn't you use TRACE_EXTRA_MAX * sizeof(u32) instead of the
>> literal 28?
>
> Indeed I should.
>
>> The literal 0x1000 also doesn't look nice - I'm no sure though
>> whether this really is (1 << TRC_SUBCLS_SHIFT).
>
> Yes it is (the guest's not allowed to define the class or subclass of
> the trace entry). How about the attached patch instead?
Great, thanks!
Jan
prev parent reply other threads:[~2010-07-09 16:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-09 13:30 [PATCH 0 of 2] New HVMOPs for PV-on-HVM drivers Tim Deegan
2010-07-09 13:30 ` [PATCH 1 of 2] Add a new HVMOP which allows an HVM guest to get the current Tim Deegan
2010-07-09 13:30 ` [PATCH 2 of 2] Add a hypercall to allow HVM PV drivers to insert xentrace records Tim Deegan
2010-07-09 14:44 ` Jan Beulich
2010-07-09 15:07 ` Tim Deegan
2010-07-09 16:02 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C376428020000780000A8B7@vpn.id2.novell.com \
--to=jbeulich@novell.com \
--cc=Tim.Deegan@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).