From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <JBeulich@novell.com>
Subject: Re: [PATCH 2 of 2] Add a hypercall to allow HVM PV
	drivers to insert xentrace records
Date: Fri, 09 Jul 2010 17:02:16 +0100
Message-ID: <4C376428020000780000A8B7@vpn.id2.novell.com>
References: <patchbomb.1278682223@waitaha.uk.xensource.com>
	<ed89d064acc184b0c10a.1278682225@waitaha.uk.xensource.com>
	<4C3751E4020000780000A81E@vpn.id2.novell.com>
	<20100709150741.GF31695@whitby.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20100709150741.GF31695@whitby.uk.xensource.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Tim Deegan <Tim.Deegan@citrix.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

>>> On 09.07.10 at 17:07, Tim Deegan <Tim.Deegan@citrix.com> wrote:
> At 15:44 +0100 on 09 Jul (1278690260), Jan Beulich wrote:
>> >>> On 09.07.10 at 15:30, Tim Deegan <Tim.Deegan@citrix.com> wrote:
>> >+        if ( tr.extra_bytes > 28 || tr.event >=3D 0x1000 )
>>=20
>> Couldn't you use TRACE_EXTRA_MAX * sizeof(u32) instead of the
>> literal 28?
>=20
> Indeed I should.
>=20
>> The literal 0x1000 also doesn't look nice - I'm no sure though
>> whether this really is (1 << TRC_SUBCLS_SHIFT).
>=20
> Yes it is (the guest's not allowed to define the class or subclass of
> the trace entry).  How about the attached patch instead?

Great, thanks!

Jan