[PATCH] Add a check script to check for the existence of an ocaml native compiler

[PATCH] Add a check script to check for the existence of an ocaml native compiler

[Vincent Hanquez]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]


The script doesn't check anything if the $OS is not linux, and just print a
warning if the compiler is missing.

Signed-off-by: Vincent Hanquez <vincent.hanquez@eu.citrix.com>
---
 tools/check/check_ocaml |   13 +++++++++++++
 1 files changed, 13 insertions(+), 0 deletions(-)
 create mode 100755 tools/check/check_ocaml


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Add-a-check-script-to-check-for-the-existence-of-an-.patch --]
[-- Type: text/x-patch; name="0001-Add-a-check-script-to-check-for-the-existence-of-an-.patch", Size: 344 bytes --]

diff --git a/tools/check/check_ocaml b/tools/check/check_ocaml
new file mode 100755
index 0000000..a29a345
--- /dev/null
+++ b/tools/check/check_ocaml
@@ -0,0 +1,13 @@
+#!/bin/sh
+# CHECK-BUILD
+
+. ./funcs.sh
+
+case $OS in
+Linux)
+	has ocamlopt >/dev/null || warning "missing ocaml native compiler"
+	;;
+*)
+	
+	;;
+esac

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH] Add a check script to check for the existence of an ocaml native compiler

[Ian Jackson]

Vincent Hanquez writes ("[Xen-devel] [PATCH] Add a check script to check for the existence of an ocaml native compiler"):
> The script doesn't check anything if the $OS is not linux, and just print a
> warning if the compiler is missing.

I don't understand the rationale behind only warning about missing
ocaml compilers on Linux.

Either there is nothing wrong with not having ocaml and using all the
C tools (specifically, C xenstore), in which case it arguably
shouldn't produce a warning; or the future is supposedly ocaml and
then we should warn everywhere.

Of course the latter situation would imply that ocaml can in practice
be found on non-Linux dom0's without too much pain.  Is that true ?

Ian.

Re: [PATCH] Add a check script to check for the existence of an ocaml native compiler

[Vincent Hanquez]

On 13/07/10 19:12, Ian Jackson wrote:
> Vincent Hanquez writes ("[Xen-devel] [PATCH] Add a check script to check for the existence of an ocaml native compiler"):
>    
>> The script doesn't check anything if the $OS is not linux, and just print a
>> warning if the compiler is missing.
>>      
> I don't understand the rationale behind only warning about missing
> ocaml compilers on Linux.
>    
Unless oxenstored get some portability efforts, warning on system that 
can't use it anyway is just annoying for no gain. On system that can use 
it (just linux), we want to push people using it.

-- 
Vincent