From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH]: fix crash in various tools by permitting xs_*() with NULL path Date: Mon, 26 Jul 2010 11:45:28 +0200 Message-ID: <4C4D5938.3060605@redhat.com> References: <1279641356.1723.1940.camel@qabil.uk.xensource.com> <19525.52837.149559.660268@mariner.uk.xensource.com> <1279645377.1723.1966.camel@qabil.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1279645377.1723.1966.camel@qabil.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Gianni Tedesco Cc: Xen Devel , Ian Jackson List-Id: xen-devel@lists.xenproject.org On 07/20/2010 07:02 PM, Gianni Tedesco wrote: > On the contrary open(NULL, O_RDONLY) will... The difference is FILE * is > a struct wheras the change I am proposing in this case is to treat NULL > as the empty string in the case of paths. Returning EFAULT is one possible outcome, but a SIGSEGV or SIGBUS is also valid according to POSIX. Paolo