xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@amd.com>
To: Yang Hongyang <yanghy@cn.fujitsu.com>,
	Keir Fraser <keir.fraser@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
Subject: [PATCH 3/3]: xl: allow long listing of Domain 0
Date: Mon, 9 Aug 2010 15:55:41 +0200	[thread overview]
Message-ID: <4C6008DD.4040306@amd.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 527 bytes --]

Hi,

currently xl list aborts when one tries to list -l Domain 0 (either 
explicitly or by listing all domains):
# xl list -l 0
Neither kernel nor bootloader specified

Ignore this error message (which is invalid for Dom0). I haven't found 
an obvious way to check for Dom0 before printing this message, so I 
simply removed the exit() call here.

Regards,
Andre.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448-3567-12

[-- Attachment #2: libxl_list_3.patch --]
[-- Type: text/x-patch, Size: 807 bytes --]

diff -r 8992134dcfd0 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c	Wed Aug 04 19:24:17 2010 +0100
+++ b/tools/libxl/xl_cmdimpl.c	Mon Aug 09 16:03:33 2010 +0200
@@ -454,7 +454,7 @@
         printf("\t\t)\n");
     } else {
         printf("\t\t(linux %d)\n", b_info->hvm);
-        printf("\t\t\t(kernel %s)\n", b_info->kernel.path);
+        printf("\t\t\t(kernel %s)\n", b_info->kernel.path ?: "");
         printf("\t\t\t(cmdline %s)\n", b_info->u.pv.cmdline);
         printf("\t\t\t(ramdisk %s)\n", b_info->u.pv.ramdisk.path);
         printf("\t\t)\n");
@@ -706,7 +706,6 @@
 
         if (!b_info->u.pv.bootloader && !b_info->kernel.path) {
             fprintf(stderr, "Neither kernel nor bootloader specified\n");
-            exit(1);
         }
 
         b_info->u.pv.cmdline = cmdline;

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2010-08-09 13:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-09 13:55 Andre Przywara [this message]
2010-08-09 16:11 ` [PATCH 3/3]: xl: allow long listing of Domain 0' Stefano Stabellini
2010-08-09 17:08   ` Gianni Tedesco
2010-08-09 17:36     ` Stefano Stabellini
2010-08-09 17:40       ` Gianni Tedesco
2010-08-10 10:07         ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C6008DD.4040306@amd.com \
    --to=andre.przywara@amd.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=yanghy@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).