libxl: Allow specification of backend domains for vifs

libxl: Allow specification of backend domains for vifs

[Mihir Nanavati]

[-- Attachment #1: Type: text/plain, Size: 1672 bytes --]

Allow specification of backend domains for vifs, either in the config
file or via network-attach.

Signed-off-by: Mihir Nanavati <mihirn@cs.ubc.ca>

diff -r 8992134dcfd0 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c	Wed Aug 04 19:24:17 2010 +0100
+++ b/tools/libxl/xl_cmdimpl.c	Mon Aug 09 15:02:56 2010 +0100
@@ -833,6 +833,11 @@
                     nic->script = strdup(p2 + 1);
                 } else if (!strcmp(p, "vifname")) {
                     nic->ifname = strdup(p2 + 1);
+                } else if (!strcmp(p, "backend")) {
+                    if(libxl_name_to_domid(&ctx, (p2 + 1),
&(nic->backend_domid))) {
+                        fprintf(stderr, "Specified backend domain
does not exist, defaulting to Dom0\n");
+                        nic->backend_domid = 0;
+                    }
                 } else if (!strcmp(p, "rate")) {
                     fprintf(stderr, "the rate parameter for vifs is
currently not supported\n");
                 } else if (!strcmp(p, "accel")) {
@@ -4001,10 +4006,9 @@
         } else if (!strncmp("script=", *argv, 6)) {
             nic.script = (*argv) + 6;
         } else if (!strncmp("backend=", *argv, 8)) {
-            val = strtoul((*argv) + 8, &endptr, 10);
-            if (((*argv) + 8) == endptr) {
-                fprintf(stderr, "Invalid parameter `backend'.\n");
-                return 1;
+            if(libxl_name_to_domid(&ctx, ((*argv) + 8), &val)) {
+                fprintf(stderr, "Specified backend domain does not
exist, defaulting to Dom0\n");
+                val = 0;
             }
             nic.backend_domid = val;
         } else if (!strncmp("vifname=", *argv, 8)) {

[-- Attachment #2: xlnetattach.patch --]
[-- Type: text/x-patch, Size: 1523 bytes --]

diff -r 8992134dcfd0 tools/libxl/xl_cmdimpl.c
--- a/tools/libxl/xl_cmdimpl.c	Wed Aug 04 19:24:17 2010 +0100
+++ b/tools/libxl/xl_cmdimpl.c	Mon Aug 09 15:02:56 2010 +0100
@@ -833,6 +833,11 @@
                     nic->script = strdup(p2 + 1);
                 } else if (!strcmp(p, "vifname")) {
                     nic->ifname = strdup(p2 + 1);
+                } else if (!strcmp(p, "backend")) {
+                    if(libxl_name_to_domid(&ctx, (p2 + 1), &(nic->backend_domid))) {
+                        fprintf(stderr, "Specified backend domain does not exist, defaulting to Dom0\n");
+                        nic->backend_domid = 0;
+                    }
                 } else if (!strcmp(p, "rate")) {
                     fprintf(stderr, "the rate parameter for vifs is currently not supported\n");
                 } else if (!strcmp(p, "accel")) {
@@ -4001,10 +4006,9 @@
         } else if (!strncmp("script=", *argv, 6)) {
             nic.script = (*argv) + 6;
         } else if (!strncmp("backend=", *argv, 8)) {
-            val = strtoul((*argv) + 8, &endptr, 10);
-            if (((*argv) + 8) == endptr) {
-                fprintf(stderr, "Invalid parameter `backend'.\n");
-                return 1;
+            if(libxl_name_to_domid(&ctx, ((*argv) + 8), &val)) {
+                fprintf(stderr, "Specified backend domain does not exist, defaulting to Dom0\n");
+                val = 0;
             }
             nic.backend_domid = val;
         } else if (!strncmp("vifname=", *argv, 8)) {

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: libxl: Allow specification of backend domains for vifs

[Stefano Stabellini]

On Mon, 9 Aug 2010, Mihir Nanavati wrote:
> Allow specification of backend domains for vifs, either in the config
> file or via network-attach.
> 
> Signed-off-by: Mihir Nanavati <mihirn@cs.ubc.ca>

applied, thanks

Re: libxl: Allow specification of backend domains for vifs

[Ian Jackson]

Mihir Nanavati writes ("[Xen-devel] libxl: Allow specification of backend domains for vifs"):
> Allow specification of backend domains for vifs, either in the config
> file or via network-attach.

What happens if you do this in the config file for an HVM guest ?

Ian.

Re: libxl: Allow specification of backend domains for vifs

[Mihir Nanavati]

It works fine with stub domains. I haven't really played around with
it on regular HVM guests, but I suspect it might cause some issues.
Will give it a spin tomorrow.

~M

On Tue, Aug 10, 2010 at 5:44 PM, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote:
> Mihir Nanavati writes ("[Xen-devel] libxl: Allow specification of backend domains for vifs"):
>> Allow specification of backend domains for vifs, either in the config
>> file or via network-attach.
>
> What happens if you do this in the config file for an HVM guest ?
>
> Ian.
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>

Re: libxl: Allow specification of backend domains for vifs

[Vincent Hanquez]

On 10/08/10 22:13, Mihir Nanavati wrote:
> It works fine with stub domains. I haven't really played around with
> it on regular HVM guests, but I suspect it might cause some issues.
> Will give it a spin tomorrow.

There's nothing different in this case. exposing the backend domid for 
hvm guest is a perfectly valid thing to do.

-- 
Vincent