From mboxrd@z Thu Jan  1 00:00:00 1970
From: Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [PATCH 14/15] xen: destroy the VM when shutdown is
	requested
Date: Fri, 13 Aug 2010 13:56:58 -0500
Message-ID: <4C65957A.3060107@codemonkey.ws>
References: <alpine.DEB.2.00.1008121244200.2545@kaball-desktop>
	<1281622202-3453-14-git-send-email-stefano.stabellini@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org>
In-Reply-To: <1281622202-3453-14-git-send-email-stefano.stabellini@eu.citrix.com>
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org
To: stefano.stabellini@eu.citrix.com
Cc: Anthony.Perard@citrix.com, xen-devel@lists.xensource.com, qemu-devel@nongnu.org
List-Id: xen-devel@lists.xenproject.org

On 08/12/2010 09:10 AM, stefano.stabellini@eu.citrix.com wrote:
> From: Anthony PERARD<anthony.perard@citrix.com>
>
> Handle shutdown and reset requests in helper.c.
>
> Signed-off-by: Anthony PERARD<anthony.perard@citrix.com>
> Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com>
> ---
>   target-xen/helper.c |   17 +++++++++++++++++
>   1 files changed, 17 insertions(+), 0 deletions(-)
>
> diff --git a/target-xen/helper.c b/target-xen/helper.c
> index 4571ac0..16e628c 100644
> --- a/target-xen/helper.c
> +++ b/target-xen/helper.c
> @@ -397,6 +397,23 @@ static void cpu_handle_ioreq(void *opaque)
>
>           xen_wmb(); /* Update ioreq contents /then/ update state. */
>
> +        /*
> +         * We do this before we send the response so that the tools
> +         * have the opportunity to pick up on the reset before the
> +         * guest resumes and does a hlt with interrupts disabled which
> +         * causes Xen to powerdown the domain.
> +         */
> +        if (vm_running) {
> +            if (qemu_shutdown_requested_get()) {
> +                fprintf(stderr, "shutdown requested in cpu_handle_ioreq\n");
> +                destroy_hvm_domain();
> +            }
>    

The patches should not introduce fprintfs in expected paths.

Regards,

Anthony Liguori

> +            if (qemu_reset_requested_get()) {
> +                fprintf(stderr, "reset requested in cpu_handle_ioreq.\n");
> +                qemu_system_reset();
> +            }
> +        }
> +
>           req->state = STATE_IORESP_READY;
>           xc_evtchn_notify(xce_handle, ioreq_local_port[send_vcpu]);
>       }
>