From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [PATCH] Remus breaks the build Date: Fri, 13 Aug 2010 14:14:13 -0700 Message-ID: <4C65B5A5.8020202@goop.org> References: <4C6493ED.3040605@goop.org> <20100813194217.GA6981@kremvax.cs.ubc.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100813194217.GA6981@kremvax.cs.ubc.ca> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson , Stefano Stabellini , Ian Campbell , "Xen-devel@lists.xensource.com" List-Id: xen-devel@lists.xenproject.org On 08/13/2010 12:42 PM, Brendan Cully wrote: > I assume you're talking about this snippet of tools/remus/kmod/Makefile: > > $(MAKE) -C $(KERNELDIR) SUBDIRS=`pwd` modules > > which expects to find a Makefile in $KERNELDIR but does the actual > building in place, in the tools/remus/kmod directory (unless the > kernel build system has changed recently?). I thought this was a > pretty standard way to build out-of-tree kernel modules. I don't ever build the kernel out of the Xen tree. In general, it assumes the kernel tree has already been configured and built, which may not be true if you're doing a parallel build, or if you're building the Xen tree piecewise. > I'm not sure why this is causing you problems (is it?), but if you're > willing to carry sch_queue in the pvops tree, I'd be happy to drop > tools/remus/kmod in the unstable tree. Yes, I'm happy to include it. Do you have a git reference I can merge from? J