[PATCH]: Fix xentrace buffer allocation

[PATCH]: Fix xentrace buffer allocation

[Andre Przywara]

[-- Attachment #1: Type: text/plain, Size: 461 bytes --]

Hi,

during experiments with xentrace we found that the t_info buffer 
allocation does not match the constants describing the buffer size.
Attached patch fixes this, so changes of the buffer size only requires a 
single line change in the future. Thanks to Uwe for reporting this.

Regards,
Andre.

Signed-off-by: Andre Przywara <andre.przywara@amd.com>

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 448-3567-12

[-- Attachment #2: fix_tinfo_allocation.patch --]
[-- Type: text/x-patch, Size: 666 bytes --]

diff -r 774dfc178c39 xen/common/trace.c
--- a/xen/common/trace.c	Thu Aug 12 17:06:21 2010 +0100
+++ b/xen/common/trace.c	Mon Aug 16 13:22:47 2010 +0200
@@ -321,9 +321,9 @@
     /* Calculate offset in u32 of first mfn */
     calc_tinfo_first_offset();
 
-    /* t_info size fixed at 2 pages for now.  That should be big enough / small enough
-     * until it's worth making it dynamic. */
-    t_info = alloc_xenheap_pages(1, 0);
+    /* t_info size is fixed for now. Currently this works great, so there
+     * seems to be no need to make it dynamic. */
+    t_info = alloc_xenheap_pages(get_order_from_pages(T_INFO_PAGES), 0);
 
     if ( t_info == NULL )
     {

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [PATCH]: Fix xentrace buffer allocation

[George Dunlap]

Not sure why the comment needs to be changed, but other than that:

Acked-by: George Dunlap <george.dunlap@citrix.com>

On Mon, Aug 16, 2010 at 12:23 PM, Andre Przywara <andre.przywara@amd.com> wrote:
> Hi,
>
> during experiments with xentrace we found that the t_info buffer allocation
> does not match the constants describing the buffer size.
> Attached patch fixes this, so changes of the buffer size only requires a
> single line change in the future. Thanks to Uwe for reporting this.
>
> Regards,
> Andre.
>
> Signed-off-by: Andre Przywara <andre.przywara@amd.com>
>
> --
> Andre Przywara
> AMD-Operating System Research Center (OSRC), Dresden, Germany
> Tel: +49 351 448-3567-12
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>