From mboxrd@z Thu Jan  1 00:00:00 1970
From: Weidong Han <weidong.han@intel.com>
Subject: Re: RE: xl fails to work with some command
Date: Fri, 27 Aug 2010 08:30:08 +0800
Message-ID: <4C770710.1040604@intel.com>
References: <749B9D3DBF0F054390025D9EAFF47F222A060143@shsmsx501.ccr.corp.intel.com>
	<749B9D3DBF0F054390025D9EAFF47F222A060CFB@shsmsx501.ccr.corp.intel.com>
	<alpine.DEB.2.00.1008231102520.2545@kaball-desktop>
	<749B9D3DBF0F054390025D9EAFF47F222A060E65@shsmsx501.ccr.corp.intel.com>
	<alpine.DEB.2.00.1008251648250.2545@kaball-desktop>
	<4C760542.7080003@intel.com>
	<alpine.DEB.2.00.1008261311520.2545@kaball-desktop>
	<20100826135017.GA3792@phenom.dumpdata.com>
	<alpine.DEB.2.00.1008261646560.2545@kaball-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <alpine.DEB.2.00.1008261646560.2545@kaball-desktop>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>, Ian Campbell <Ian.Campbell@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
List-Id: xen-devel@lists.xenproject.org

Stefano Stabellini wrote:
> On Thu, 26 Aug 2010, Konrad Rzeszutek Wilk wrote:
>   
>> On Thu, Aug 26, 2010 at 01:17:08PM +0100, Stefano Stabellini wrote:
>>     
>>> On Thu, 26 Aug 2010, Weidong Han wrote:
>>>       
>>>> Stefano Stabellini wrote:
>>>>         
>>>>> On Mon, 23 Aug 2010, Zhang, Yang Z wrote:
>>>>>   
>>>>>           
>>>>>>>> 6.  vcpu-set is not supported by xl. So some RAS case which use xl vcpu-set
>>>>>>>>         
>>>>>>>>                 
>>>>>>> to set guest's cpu set will fails. case "vcpu_hot_add_64_g32e" fails.
>>>>>>>       
>>>>>>> actually vcpu-set is supported by xl, have you found any bugs using it?
>>>>>>>       
>>>>>>>               
>>>>>> For pv guest, it work well. But for HVM guest, xl miss some function about cpu hotplug which was added recently.
>>>>>>
>>>>>> xl seems only support FLR and didn't support Second Bus Reset and D0/D3. Will you add them in xl?
>>>>>>     
>>>>>>             
>>>>>  
>>>>> xl uses the sysfs "reset" node provided by the pci subsystem of the
>>>>> Linux kernel, that should support Secondary Bus Reset and D0/D3 already.
>>>>>   
>>>>>           
>>>> Do you mean xl uses Linux kernel PCI API (i.e. pci_reset_function) to 
>>>> reset PCI device?
>>>>         
>>> Yes, give a look at libxl_device_pci_reset: first libxl tries to use the
>>> pciback sysfn node "do_flr", but if it is not present it will use the
>>> standard linux sysfs "reset" node.
>>> Please note that on pvops kernels the do_flr node is not present (but it
>>> is present on both XCP and XCI kernels) while the reset node points to
>>> pci_reset_function.
>>>       
>> <hint>I am all up for receiving the patches from XCP/XCI for this</hint>
>>
>>     
>
> I think that using the standard linux reset mechanism is a better way to
> handle this as oppose to have our own do_flr method.
>   
Pls note that there are some specific FLR functions for graphics 
pass-through. They should be ported to xl.

Regards,
Weidong