From mboxrd@z Thu Jan  1 00:00:00 1970
From: Weidong Han <weidong.han@intel.com>
Subject: Re: RE: xl fails to work with some command
Date: Tue, 31 Aug 2010 15:07:08 +0800
Message-ID: <4C7CAA1C.1030902@intel.com>
References: <749B9D3DBF0F054390025D9EAFF47F222A060143@shsmsx501.ccr.corp.intel.com>
	<749B9D3DBF0F054390025D9EAFF47F222A060CFB@shsmsx501.ccr.corp.intel.com>
	<alpine.DEB.2.00.1008231102520.2545@kaball-desktop>
	<749B9D3DBF0F054390025D9EAFF47F222A060E65@shsmsx501.ccr.corp.intel.com>
	<alpine.DEB.2.00.1008251648250.2545@kaball-desktop>
	<4C760542.7080003@intel.com>
	<alpine.DEB.2.00.1008261311520.2545@kaball-desktop>
	<20100826135017.GA3792@phenom.dumpdata.com>
	<alpine.DEB.2.00.1008261646560.2545@kaball-desktop>
	<4C770710.1040604@intel.com>
	<alpine.DEB.2.00.1008271151110.2545@kaball-desktop>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <alpine.DEB.2.00.1008271151110.2545@kaball-desktop>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>, Ian Campbell <Ian.Campbell@eu.citrix.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
List-Id: xen-devel@lists.xenproject.org

Stefano Stabellini wrote:
> On Fri, 27 Aug 2010, Weidong Han wrote:
>   
>>>>> Yes, give a look at libxl_device_pci_reset: first libxl tries to use the
>>>>> pciback sysfn node "do_flr", but if it is not present it will use the
>>>>> standard linux sysfs "reset" node.
>>>>> Please note that on pvops kernels the do_flr node is not present (but it
>>>>> is present on both XCP and XCI kernels) while the reset node points to
>>>>> pci_reset_function.
>>>>>       
>>>>>           
>>>> <hint>I am all up for receiving the patches from XCP/XCI for this</hint>
>>>>
>>>>     
>>>>         
>>> I think that using the standard linux reset mechanism is a better way to
>>> handle this as oppose to have our own do_flr method.
>>>   
>>>       
>> Pls note that there are some specific FLR functions for graphics 
>> pass-through. They should be ported to xl.
>>
>>     
>  
> As stated above, xl doesn't know how to FLR a device, the dom0 kernel
> provides a way to do it.
> XCP kernels have pciback do_flr that has all the HW specific FLR
> functions you are referring to AFAIK, but the pvops kernel, that uses
> the standard reset node, does not.
>
>   
So it should implement specific FLRs in pciback like XCP/XCI.

Regards,
Weidong