From mboxrd@z Thu Jan  1 00:00:00 1970
From: Weidong Han <weidong.han@intel.com>
Subject: Re: RE: xl fails to work with some command
Date: Tue, 31 Aug 2010 21:04:40 +0800
Message-ID: <4C7CFDE8.50105@intel.com>
References: <749B9D3DBF0F054390025D9EAFF47F222A060143@shsmsx501.ccr.corp.intel.com>	
	<749B9D3DBF0F054390025D9EAFF47F222A060CFB@shsmsx501.ccr.corp.intel.com>	
	<alpine.DEB.2.00.1008231102520.2545@kaball-desktop>	
	<749B9D3DBF0F054390025D9EAFF47F222A060E65@shsmsx501.ccr.corp.intel.com>	
	<alpine.DEB.2.00.1008251648250.2545@kaball-desktop>	
	<4C760542.7080003@intel.com>	
	<alpine.DEB.2.00.1008261311520.2545@kaball-desktop>	
	<20100826135017.GA3792@phenom.dumpdata.com>	
	<alpine.DEB.2.00.1008261646560.2545@kaball-desktop>	
	<4C770710.1040604@intel.com>	
	<alpine.DEB.2.00.1008271151110.2545@kaball-desktop>	
	<4C7CAA1C.1030902@intel.com>	
	<alpine.DEB.2.00.1008311038320.18383@kaball-desktop>
	<1283249247.12544.9361.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1283249247.12544.9361.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Campbell <Ian.Campbell@eu.citrix.com>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

Ian Campbell wrote:
> On Tue, 2010-08-31 at 10:40 +0100, Stefano Stabellini wrote:
>   
>> On Tue, 31 Aug 2010, Weidong Han wrote:
>>     
>>>> As stated above, xl doesn't know how to FLR a device, the dom0 kernel
>>>> provides a way to do it.
>>>> XCP kernels have pciback do_flr that has all the HW specific FLR
>>>> functions you are referring to AFAIK, but the pvops kernel, that uses
>>>> the standard reset node, does not.
>>>>
>>>>   
>>>>         
>>> So it should implement specific FLRs in pciback like XCP/XCI.
>>>
>>>       
>>  
>> Why should we reimplement pci FLR in pciback when the kernel has
>> already a way to do it?
>> I am not seeing pciback FLR going upstream easily.
>> Besides if some devices need specific FLRs, shouldn't the generic kernel
>> FLR function know about it?
>>     
>
> Yes, absolutely, the correct way to fix this is to add the necessary
> fixes/quirks to the upstream FLR infrastructure so that everybody
> benefits, not to add stuff to pciback where a) only Xen benefits and b)
> we have to maintain it forever because it cannot be upstreamed because
> the correct fix is to fix it in the upstream LFR infrastructure ;-).
>
> Ian.
>
>
> I totally agree with you. It's the best to push the specific FLRs to Linux FLR infrastructure. I'm afraid it will need many efforts. But it's the right direction anyway.
Regards,
Weidong
>