From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Klose Subject: Re: [Pkg-xen-devel] using xen tools with python2.6 Date: Mon, 13 Sep 2010 10:57:47 +0200 Message-ID: <4C8DE78B.10709@debian.org> References: <4C8CE2BD.2000404@debian.org> <1284367127.14311.14256.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1284367127.14311.14256.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: xen@packages.debian.org, xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On 13.09.2010 10:38, Ian Campbell wrote: > On Sun, 2010-09-12 at 16:25 +0200, Matthias Klose wrote: >> there are at least some syntax errors when trying to use the xen utils with >> python2.6. The attached patch changes these string exception into ValueError's. > > Thanks Matthias. > >> - tools/python/xen/util/bugtool.py (getBugTitle) >> - tools/python/xen/xend (class XendBase): not catched >> - tools/python/xen/xm/xenapi_create.py (sxp2xmlconvert_sxp_to_xml): >> the method already raises a ValueError for similiar condition. >> - tools/python/xen/xm/main.py (xm_network_attach): not catched. >> >> For all but maybe the first one, the replacement of the string exceptions into >> ValueError's seems to be safe. > > Why is the first one potentially unsafe? because I didn't check where it's used. > What do you mean by "not catched" here? Just that nothing catches the > exception? yes, and the first one seems to match this definition too. > Please could you provide a Signed-off-by line for upstream? hmm, any pointers? I hope my friendly distribution packager could help ... Matthias