Re: PCI hotplug problem

["Jan Beulich" <JBeulich@novell.com>]

>>> On 01.10.10 at 16:24, Rafal Wojtczuk <rafal@invisiblethingslab.com> wrote:
> There is one more problem with the linux-2.6.18-xen.hg pcifront (that affect
> derived code, e.g. OpenSUSE kernel, too). unbind_from_irqhandler() is
> mistakenly passed evtchn, instead of irq. Compare line 68 of
> http://xenbits.xensource.com/linux-2.6.18-xen.hg?file/a66a7c64b1d0/drivers/xen 
> /pcifront/xenbus.c
> with pvops equivalent
> http://git.kernel.org/?p=linux/kernel/git/jeremy/xen.git;a=blob;f=drivers/pc 
> i/xen-pcifront.c;h=10868aeae818d69980b8519f8a77b38d6ab58a4c;hb=HEAD#l758
> 
> The following patch helps.

Except there is no irq_from_evtchn() in the original tree. I'll post a
better, more complete patch later.

Jan

> Regards,
> Rafal Wojtczuk
> 
> 
> unbind_from_irqhandler takes irq, not evtchn, as its first argument.
> 
> Signed-off-by: Rafal Wojtczuk <rafal@invisiblethingslab.com>
> --- linux-2.6.34.1/drivers/xen/pcifront/xenbus.c.orig   2010-09-29 
> 16:47:39.961674359 +0200
> +++ linux-2.6.34.1/drivers/xen/pcifront/xenbus.c        2010-09-29 
> 16:47:49.458675391 +0200
> @@ -61,7 +61,7 @@ static void free_pdev(struct pcifront_de
> 
>         /*For PCIE_AER error handling job*/
>         flush_scheduled_work();
> -       unbind_from_irqhandler(pdev->evtchn, pdev);
> +       unbind_from_irqhandler(irq_from_evtchn(pdev->evtchn), pdev);
> 
>         if (pdev->evtchn != INVALID_EVTCHN)
>                 xenbus_free_evtchn(pdev->xdev, pdev->evtchn);