From mboxrd@z Thu Jan  1 00:00:00 1970
From: Weidong Han <weidong.han@intel.com>
Subject: Re: RE: kernel panic when enable x2apic
Date: Wed, 01 Dec 2010 08:42:50 +0800
Message-ID: <4CF59A0A.5040400@intel.com>
References: <C91A9347.B7D7%keir@xen.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C91A9347.B7D7%keir@xen.org>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir@xen.org>
Cc: "Zhang, Yang Z" <yang.z.zhang@intel.com>, Sander Eikelenboom <linux@eikelenboom.it>, "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>, Jan Beulich <JBeulich@novell.com>
List-Id: xen-devel@lists.xenproject.org

Keir Fraser wrote:
> On 30/11/2010 09:23, "Keir Fraser" <keir@xen.org> wrote:
>
>   
>>> The obvious solution is to remove
>>> boot_cpu_data.x86_capability[4] = cpuid_ecx(1) in start_vmx. It indeed
>>> works with the change. I will send out the patch after more tests.
>>>       
>> Yes, the write to x86_capability is totally unnecessary. There is a similar
>> pointless one in SVM code -- in fact they don't even manage to write to the
>> correct array element of x86_capability[]!
>>
>> Removing both writes to x86_capability[] would be an appropriate fix for 4.0
>> branch as well.
>>     
>
> I applied a fix to xen-unstable and xen-4.0-testing. Eyeballing plus a quick
> test convinces me it is absolutely fine. I credited you in the changeset
> comment, I hope that's okay.
>
>   
Great!

Regards,
Weidong